serviceAccountNameOverride helm parm to add RBAC #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when using the serviceAccountNameOverride we assumed that the ServiceAccount was fully setup. So, we didn't apply any RBAC rules to the ServiceAccount. To make it easier to deploy with an existing ServiceAccount, we will now apply the Role/RoleBinding creation to the given ServiceAccount. This makes it easier to use AWS IRSA with a precreated serviceAccount. The operator will apply the RBAC rules needed by the operator the serviceAccount specified. The old behavior existed to allow for helm install by users that don't have admin privileges to the k8s cluster. To get the old behaviour you need to use set a new parameter 'skipRoleAndRoleBindingCreation=true'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when using the serviceAccountNameOverride we assumed that the ServiceAccount was fully setup. So, we didn't apply any RBAC rules to the ServiceAccount. To make it easier to deploy with an existing ServiceAccount, we will now apply the Role/RoleBinding creation to the given ServiceAccount.
This makes it easier to use AWS IRSA (#200), which requires a preexisting ServiceAccount. The operator will apply the RBAC rules needed by the operator the ServiceAccount specified.
The old behaviour existed to allow for helm install by users that don't have admin privileges to the k8s cluster. To get the old behaviour you need to use set a new parameter 'skipRoleAndRoleBindingCreation=true'.