Prevent negative values for requeue times #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see this as being a common pattern, main is frozen while QA tests, but to continue developing the operator we do new changes on vnext. This will become main after the next release. To aid in testing of this branch, all pushes to vnext will do the e2e tests now.
There are two parms in the CR that allow you to control the requeue time of a controller reconciler iteration. Both of these parameters could be assigned negative values. This PR adds new rules to the webhook to prevent that.
roypaulin
reviewed
May 3, 2022
| @@ -890,6 +890,7 @@ func MakeVDB() *VerticaDB { | |||
| DataPath: "/data", | |||
| DepotPath: "/depot", | |||
| }, | |||
| KSafety: KSafety1, | |||
There was a problem hiding this comment.
I used the MakeVDB() function in the webhook UT. When I tried to test the successful case, where the requeue times were valid, it still complained that the kSafety was not valid. We just never set it properly, so any webhook test will complain about it.
roypaulin
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two parms in the CR that allow you to control the requeue time of a controller reconciler iteration. Both of these parameters could be assigned negative values. This PR adds new rules to the webhook to prevent that.