Restart to handle read-only Vertica nodes #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
reviewed
Dec 6, 2021
pkg/controllers/podfacts.go
Outdated
| } else { | ||
| pf.upNode = true | ||
| pf.readOnly = false |
There was a problem hiding this comment.
What happens here with respect to line 373?
There was a problem hiding this comment.
This is check if we are on a server without the read-only state. So it will always be false. I suppose, to avoid duplication I can set it only once in this function.
|
Other than my comment, it looks good. |
|
looks good thanks |
roypaulin
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to the restart processing to handle the new read-only state in 11.0SP2. If you lose cluster quorum, nodes that were up stay up node and are put into read-only state. The operator needs to kill those processes before it can do a full cluster restart.
This collects the read-only state (11.0SP2 only), then treats them as down nodes when we restart. The restart reconciler already had code that send a kill signal to running vertica processes.
I also rename the restart testcase to restart-sanity. This was done so that we can run just this testcase within kuttl. kuttl --test option will match all test cases that have the argument in its name. So, trying to run with
kubectl kuttl test --test restartwould match auto-restart-vertica, restart-node-multi-sc and restart. The new name means we can run just that single test viakubectl kuttl --test restart-sanity