Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] fix: overlay is located relatively low when long content #76113

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 17, 2025

Why?

The overlay seemed too low when the content was long since it had both padding and top values. Adjust to have only the top and preserve the padding value.

Before

CleanShot.2025-02-17.at.23.32.04.mp4

After

CleanShot.2025-02-17.at.23.32.38.mp4

Closes NDX-845

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 17, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 17, 2025 13:33
Copy link
Member Author

devjiwonchoi commented Feb 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@@ -169,9 +170,15 @@ export const Turbopack: Story = {
},
}

export const Minimized: Story = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not doing anything.

@ijjk
Copy link
Member

ijjk commented Feb 17, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
buildDuration 22.3s 19.8s N/A
buildDurationCached 18.3s 15.4s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +38.5 kB
nextStartRea..uration (ms) 475ms 475ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
5306-HASH.js gzip 55.3 kB 55.3 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 55.1 kB 55.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
index.html gzip 522 B 522 B
link.html gzip 538 B 536 B N/A
withRouter.html gzip 519 B 518 B N/A
Overall change 522 B 522 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
middleware-b..fest.js gzip 677 B 674 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
app-page-exp...dev.js gzip 395 kB 395 kB N/A
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 384 kB 384 kB N/A
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 898 kB 898 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-17-_dev-overlay_fix_position_moved_down_when_long_content Change
0.pack gzip 2.12 MB 2.12 MB ⚠️ +678 B
index.pack gzip 77.1 kB 76.1 kB N/A
Overall change 2.12 MB 2.12 MB ⚠️ +678 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 1759e73

@devjiwonchoi devjiwonchoi requested a review from gaojude February 17, 2025 14:42
@devjiwonchoi devjiwonchoi changed the title [dev-overlay] fix: position moved down when long content [dev-overlay] fix: overlay is located relatively low when long content Feb 17, 2025
@devjiwonchoi devjiwonchoi merged commit 16523ba into canary Feb 18, 2025
134 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-17-_dev-overlay_fix_position_moved_down_when_long_content branch February 18, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants