Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turboyet): Upload test data for both bundlers #76090

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Feb 16, 2025

Tested by commenting out the turbopack upload bits (since I don't want to risk messing up that dataset) and running:

TURBOYET_KV_REST_API_TOKEN="..." TURBOYET_KV_REST_API_URL="..." node .github/actions/upload-turboyet-data/dist/index.js

I got the API token from the areweturboyet deployment in the vercel dashboard.

I think it's fine and easiest to just use the same KV database for both bundlers with different key prefixes.

Closes PACK-3981

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. tests labels Feb 16, 2025
Copy link
Member Author

bgw commented Feb 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Feb 16, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
buildDuration 19.6s 16.7s N/A
buildDurationCached 15.8s 13.1s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 434ms 439ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
5306-HASH.js gzip 55.2 kB 55.2 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 55.1 kB 55.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
index.html gzip 523 B 522 B N/A
link.html gzip 539 B 535 B N/A
withRouter.html gzip 519 B 517 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
middleware-b..fest.js gzip 675 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
app-page-exp...dev.js gzip 395 kB 395 kB
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 384 kB 384 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 1.68 MB 1.68 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/upload-turboyet-data Change
0.pack gzip 2.11 MB 2.12 MB ⚠️ +2.57 kB
index.pack gzip 76.9 kB 76.2 kB N/A
Overall change 2.11 MB 2.12 MB ⚠️ +2.57 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 83ef9ea

@bgw bgw marked this pull request as ready for review February 16, 2025 03:52
@ijjk
Copy link
Member

ijjk commented Feb 16, 2025

Tests Passed

@bgw bgw merged commit 8860192 into canary Feb 18, 2025
131 checks passed
Copy link
Member Author

bgw commented Feb 18, 2025

Merge activity

  • Feb 18, 2:07 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/upload-turboyet-data branch February 18, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants