Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] fix: terminal symbols are longer than text #76059

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 14, 2025

Why?

There's a width mismatch for symbols used in Geist Mono font font-weight over 600.

Before After
CleanShot 2025-02-15 at 01 42 01 CleanShot 2025-02-15 at 01 42 16

How?

Use font-weight 500 for bold for now.

Closes NDX-821

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 14, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
buildDuration 38.8s 36s N/A
buildDurationCached 32.6s 28s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +10.7 kB
nextStartRea..uration (ms) 995ms 972ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
5271-HASH.js gzip 55.4 kB 55.4 kB N/A
6228c9d4-HASH.js gzip 56.9 kB 56.9 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 244 B 246 B N/A
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 1.88 kB 1.88 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 328 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
index.html gzip 523 B 523 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 518 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 214 kB 214 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
middleware-b..fest.js gzip 677 B 674 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.6 kB 31.6 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
app-page-exp...dev.js gzip 395 kB 395 kB N/A
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB N/A
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 900 kB 900 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 78 kB 78.1 kB ⚠️ +105 B
Overall change 78 kB 78.1 kB ⚠️ +105 B
Diff details
Diff for 5271-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 8de86c3

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Failing test suites

Commit: 8de86c3

pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts

  • persistent-caching > should persistent cache loaders
Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1739552608508"
Received: "Timestamp = 1739552629895"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 14, 2025 16:52
@devjiwonchoi devjiwonchoi merged commit eb66a4d into canary Feb 14, 2025
130 of 132 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-15-_dev-overlay_fix_terminal_symbols_are_longer_than_text branch February 14, 2025 19:19
devjiwonchoi added a commit that referenced this pull request Feb 14, 2025
### Why?

There's a width mismatch for symbols used in Geist Mono font font-weight
over 600.

| Before | After |
|--------|--------|
| ![CleanShot 2025-02-15 at 01 42
01](https://github.com/user-attachments/assets/534bacd9-8d0a-4980-8db4-024b1fd93a3f)
| ![CleanShot 2025-02-15 at 01 42
16](https://github.com/user-attachments/assets/008418a9-0c1b-4fbe-8226-5d4fbaa8b312)
|

### How?

Use font-weight `500` for bold for now.

Closes NDX-821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants