[dev-overlay] add aria to disabled docs button

[devjiwonchoi]

The tooltip from the title property was missing when the docs button was disabled.

Closes NDX-798

[devjiwonchoi]

• [dev-overlay] add aria to disabled docs button #76055 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: 9af0c36

pnpm test-dev-turbo test/development/acceptance/server-component-compiler-errors-in-pages.test.ts (turbopack)

• Error Overlay for server components compiler errors in pages > importing 'next/cache' APIs in pages > revalidatePath is not allowed

Expand output

● Error Overlay for server components compiler errors in pages › importing 'next/cache' APIs in pages › revalidatePath is not allowed

Expected Redbox but found no visible one.

  225 |       )
  226 |
> 227 |       await session.assertHasRedbox()
      |       ^
  228 |       await expect(session.getRedboxSource()).resolves.toMatch(
  229 |         `You're importing a component that needs "${api}". That only works in a Server Component which is not supported in the pages/ directory.`
  230 |       )

  at development/acceptance/server-component-compiler-errors-in-pages.test.ts:227:7

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
buildDuration	26.8s	24.7s	N/A
buildDurationCached	22.7s	20.2s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	719ms	738ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
5271-HASH.js gzip	55.4 kB	55.4 kB	N/A
6228c9d4-HASH.js gzip	56.9 kB	56.9 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	244 B	246 B	N/A
main-HASH.js gzip	34.9 kB	34.9 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	1.88 kB	1.88 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	328 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	537 B	N/A
withRouter.html gzip	519 B	518 B	N/A
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	214 kB	214 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
middleware-b..fest.js gzip	677 B	674 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.6 kB	31.6 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
app-page-exp...dev.js gzip	395 kB	395 kB	N/A
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	382 kB	382 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	41 kB	41 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	900 kB	900 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-15-_dev-overlay_add_aria_to_disabled_docs_button	Change
0.pack gzip	2.12 MB	2.12 MB	⚠️ +423 B
index.pack gzip	76.7 kB	78.7 kB	⚠️ +2.06 kB
Overall change	2.2 MB	2.2 MB	⚠️ +2.48 kB

Diff details

Diff for 5271-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 9af0c36

[eps1lon]

A bit surprised that this works since disabled elements are not subject to pointer events. But I double checked that the native title still works so one point for title attribute over custom tooltips.