Remove tracestate header from fetch cache key #76041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
gaojude
approved these changes
Feb 14, 2025
devjiwonchoi
pushed a commit
that referenced
this pull request
Feb 14, 2025
|
Saw that you mention Sentry here. We're neither using the traceparent nor the tracestate header. Just fyi. (we're using 'baggage' and 'sentry-trace') |
|
Ah alright, I saw the dynamic sampling context in our tracestate headers but knowing otel some other library could be the culprit here. Will dive into it a bit more, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change removes the
tracestateheader from the fetch cache key.Why?
Next to
traceparentthis is also a W3C trace context header that can differ on every request leading rendering the fetch cache and deduplication useless. For example Sentry will add a random sample value to each request.With this change it should remove all the trace context headers as defined here.