Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] avoid creating many ModuleOptions #76035

Merged
merged 3 commits into from
Feb 14, 2025
Merged

[Turbopack] avoid creating many ModuleOptions #76035

merged 3 commits into from
Feb 14, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 14, 2025 •
edited by padmaia
Loading

Closes PACK-3969

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 14, 2025
@sokra Graphite App
Copy link
Member Author

sokra commented Feb 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Feb 14, 2025
Merged
@sokra sokra changed the title avoid creating many ModuleOptions [Turbopack] avoid creating many ModuleOptions Feb 14, 2025
@sokra sokra marked this pull request as ready for review February 14, 2025 05:28
@sokra sokra requested a review from mischnic February 14, 2025 05:28
@ijjk
Copy link
Member

ijjk commented Feb 14, 2025 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/less-module-options Change
buildDuration 19.6s 17s N/A
buildDurationCached 16s 13.5s N/A
nodeModulesSize 393 MB 393 MB ✓
nextStartRea..uration (ms) 423ms 444ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/less-module-options Change
5271-HASH.js gzip 55.4 kB 55.4 kB N/A
6228c9d4-HASH.js gzip 56.9 kB 56.9 kB N/A
7048.HASH.js gzip 168 B 168 B ✓
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 244 B 245 B N/A
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB ✓
Overall change 1.88 kB 1.88 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/less-module-options Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/less-module-options Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B ✓
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB ✓
routerDirect..HASH.js gzip 328 B 326 B N/A
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 325 B 325 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.72 kB 3.72 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/less-module-options Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/less-module-options Change
index.html gzip 523 B 522 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 518 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/less-module-options Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 214 kB 214 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/less-module-options Change
middleware-b..fest.js gzip 676 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.6 kB 31.6 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/less-module-options Change
app-page-exp...dev.js gzip 395 kB 395 kB ✓
app-page-exp..prod.js gzip 133 kB 133 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 382 kB 382 kB ✓
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.4 kB 39.4 kB ✓
app-route-ex..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route.ru...dev.js gzip 41 kB 41 kB ✓
app-route.ru..prod.js gzip 25.5 kB 25.5 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 31.6 kB 31.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 61.2 kB 61.2 kB ✓
Overall change 1.68 MB 1.68 MB ✓
build cache
vercel/next.js canary vercel/next.js sokra/less-module-options Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 77.3 kB 76.2 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for 5271-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: d94b800

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025 •
edited
Loading

Tests Passed

@sokra sokra force-pushed the sokra/avoid-queue-allocation branch from 932e5f1 to 04f1b13 Compare February 14, 2025 08:37
@sokra sokra force-pushed the sokra/less-module-options branch from 987d12d to fbdaaf8 Compare February 14, 2025 08:38
@sokra sokra force-pushed the sokra/avoid-queue-allocation branch 2 times, most recently from 4d60830 to 9cb3ed2 Compare February 14, 2025 09:06
@sokra sokra force-pushed the sokra/less-module-options branch from fbdaaf8 to b119a53 Compare February 14, 2025 09:06
@sokra sokra changed the base branch from sokra/avoid-queue-allocation to graphite-base/76035 February 14, 2025 09:45
@sokra sokra force-pushed the sokra/less-module-options branch from b119a53 to 2dd2376 Compare February 14, 2025 09:45
@sokra sokra force-pushed the graphite-base/76035 branch from 9cb3ed2 to 71d8bfc Compare February 14, 2025 09:45
@sokra sokra changed the base branch from graphite-base/76035 to canary February 14, 2025 09:46
@sokra sokra force-pushed the sokra/less-module-options branch from 2dd2376 to 38c2caf Compare February 14, 2025 09:46
@sokra sokra merged commit 1b0dad1 into canary Feb 14, 2025
132 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Feb 14, 2025

Merge activity

  • Feb 14, 5:41 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/less-module-options branch February 14, 2025 10:41
devjiwonchoi pushed a commit that referenced this pull request Feb 14, 2025
@sokra @devjiwonchoi
[Turbopack] avoid creating many ModuleOptions (#76035)
6410e7f 
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @mischnic