Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] add tracing to turbopack-tests #76033

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 14, 2025

What?

  • add tracing to turbopack-tests
  • remove env-filter from turbopack-cli
  • add empty feature list

Closes PACK-3968

Copy link
Member Author

sokra commented Feb 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra changed the title add tracing to turbopack-tests [Turbopack] add tracing to turbopack-tests Feb 14, 2025
@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
buildDuration 20.7s 19.3s N/A
buildDurationCached 18.1s 15.3s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 486ms 469ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
5271-HASH.js gzip 55.4 kB 55.4 kB N/A
6228c9d4-HASH.js gzip 56.9 kB 56.9 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 1.88 kB 1.88 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 328 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
index.html gzip 523 B 522 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 518 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 214 kB 214 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
middleware-b..fest.js gzip 676 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.6 kB 31.6 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
app-page-exp...dev.js gzip 395 kB 395 kB
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 1.68 MB 1.68 MB
build cache
vercel/next.js canary vercel/next.js sokra/tracing-for-tests Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 77.4 kB 76.5 kB N/A
Overall change 0 B 0 B
Diff details
Diff for 5271-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 028b49d

@sokra sokra marked this pull request as ready for review February 14, 2025 05:28
@sokra sokra requested a review from mischnic February 14, 2025 05:29
@sokra sokra changed the base branch from sokra/fix-active-counting to graphite-base/76033 February 14, 2025 08:35
@mischnic
Copy link
Contributor

So this unconditionally turns on tracing for the tests? If this is only for debugging, should we make enable it based on an env var like the CLI?

@sokra sokra force-pushed the sokra/tracing-for-tests branch from 6dcf760 to 36aef5e Compare February 14, 2025 08:39
@sokra sokra force-pushed the graphite-base/76033 branch from 37a34e3 to f9fcae1 Compare February 14, 2025 08:39
@sokra sokra changed the base branch from graphite-base/76033 to canary February 14, 2025 08:39
@sokra sokra force-pushed the sokra/tracing-for-tests branch from 36aef5e to 028b49d Compare February 14, 2025 08:39
@timneutkens timneutkens merged commit 4abde4f into canary Feb 14, 2025
132 checks passed
@timneutkens timneutkens deleted the sokra/tracing-for-tests branch February 14, 2025 10:33
devjiwonchoi pushed a commit that referenced this pull request Feb 14, 2025
### What?

* add tracing to turbopack-tests
* remove env-filter from turbopack-cli
* add empty feature list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants