Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] fix hanging and flaky issues #76032

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 14, 2025

What?

  • fix active counting when balancing edges
  • release lock correctly to avoid a deadlock

Closes PACK-3964

Copy link
Member Author

sokra commented Feb 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
buildDuration 19.5s 19.5s N/A
buildDurationCached 15.9s 13.3s N/A
nodeModulesSize 393 MB 393 MB N/A
nextStartRea..uration (ms) 443ms 440ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
5271-HASH.js gzip 55.4 kB 55.1 kB N/A
6228c9d4-HASH.js gzip 56.9 kB 53 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.9 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 1.88 kB 1.88 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 328 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
index.html gzip 523 B 521 B N/A
link.html gzip 539 B 534 B N/A
withRouter.html gzip 520 B 516 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
edge-ssr.js gzip 130 kB 130 kB ⚠️ +210 B
page.js gzip 214 kB 211 kB N/A
Overall change 130 kB 130 kB ⚠️ +210 B
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
middleware-b..fest.js gzip 677 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.6 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
app-page-exp...dev.js gzip 395 kB 394 kB N/A
app-page-exp..prod.js gzip 133 kB 133 kB N/A
app-page-tur..prod.js gzip 145 kB 145 kB N/A
app-page-tur..prod.js gzip 141 kB 141 kB N/A
app-page.run...dev.js gzip 382 kB 382 kB N/A
app-page.run..prod.js gzip 129 kB 129 kB N/A
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB N/A
app-route-tu..prod.js gzip 25.7 kB 25.7 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB N/A
Overall change 239 kB 239 kB
build cache
vercel/next.js canary vercel/next.js sokra/fix-active-counting Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 78.7 kB 76.6 kB N/A
Overall change 0 B 0 B
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 5271-HASH.js

Diff too large to display

Diff for 6228c9d4-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js
failed to diff
Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 37a34e3

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Tests Passed

@sokra sokra merged commit f9fcae1 into canary Feb 14, 2025
133 checks passed
@sokra sokra deleted the sokra/fix-active-counting branch February 14, 2025 08:35
devjiwonchoi pushed a commit that referenced this pull request Feb 14, 2025
### What?

* fix active counting when balancing edges
* release lock correctly to avoid a deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants