ensure test files are populated in next deploy #76026

gaojude · 2025-02-13T22:16:11Z

We changed how test files are populated in the test dir at #75906; specifically by moving that work to beforeInstall. For next deploy tests, we do not really install anything, resulting in deploy tests to fail due to empty projects. Thus, this PR makes sure that next deploy flow continues to have the test files populated under the test dir.

gaojude · 2025-02-13T22:16:30Z

ensure test files are populated in next deploy #76026 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-13T22:19:07Z

Failing test suites

Commit: 395bef6

pnpm test-start test/e2e/app-dir/app-alias/app-alias.test.ts

app-dir alias > should handle typescript paths alias correctly
app-dir alias > should resolve css imports from outside with src folder presented
app-dir alias > should not contain installed react/react-dom version in client chunks
app-dir alias > should generate app-build-manifest correctly

Expand output

● app-dir alias › should handle typescript paths alias correctly

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● app-dir alias › should resolve css imports from outside with src folder presented

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● app-dir alias › should not contain installed react/react-dom version in client chunks

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● app-dir alias › should generate app-build-manifest correctly

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/action-in-pages-router/action-in-pages-router.test.ts (PPR)

app-dir - action-in-pages-router > should not error on fake server action in pages router
app-dir - action-in-pages-router > should not contain server action in page bundle
app-dir - action-in-pages-router > should not contain server action in manifest

Expand output

● app-dir - action-in-pages-router › should not error on fake server action in pages router

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● app-dir - action-in-pages-router › should not contain server action in page bundle

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

● app-dir - action-in-pages-router › should not contain server action in manifest

next build failed with code/signal 1

  106 |           if (code || signal)
  107 |             reject(
> 108 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  109 |             )
  110 |           else resolve()
  111 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:108:15)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-02-13T22:25:44Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
buildDuration	20.7s	18s	N/A
buildDurationCached	17s	14.4s	N/A
nodeModulesSize	393 MB	393 MB	✓
nextStartRea..uration (ms)	465ms	460ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
5271-HASH.js gzip	55.4 kB	55.4 kB	N/A
6228c9d4-HASH.js gzip	56.9 kB	56.9 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	246 B	N/A
main-HASH.js gzip	34.9 kB	34.9 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	1.88 kB	1.88 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	328 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
index.html gzip	523 B	522 B	N/A
link.html gzip	539 B	535 B	N/A
withRouter.html gzip	519 B	517 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	214 kB	214 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
middleware-b..fest.js gzip	677 B	675 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.6 kB	31.6 kB	✓
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	32.5 kB	32.5 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
app-page-exp...dev.js gzip	395 kB	395 kB	✓
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	382 kB	382 kB	✓
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	41 kB	41 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	1.68 MB	1.68 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-13-ensure_test_files_are_populated_in_next_deploy	Change
0.pack gzip	2.12 MB	2.12 MB	⚠️ +992 B
index.pack gzip	77.8 kB	76.9 kB	N/A
Overall change	2.12 MB	2.12 MB	⚠️ +992 B

Diff details

Diff for 5271-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 395bef6

gaojude · 2025-02-13T22:30:45Z

Fixed by #76018

ensure test files are populated in next deploy

395bef6

ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Feb 13, 2025

gaojude requested review from eps1lon and ztanner February 13, 2025 22:18

gaojude marked this pull request as ready for review February 13, 2025 22:18

ztanner approved these changes Feb 13, 2025

View reviewed changes

gaojude closed this Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ensure test files are populated in next deploy #76026

ensure test files are populated in next deploy #76026

gaojude commented Feb 13, 2025 •

edited

Loading

gaojude commented Feb 13, 2025

ijjk commented Feb 13, 2025 •

edited

Loading

ijjk commented Feb 13, 2025

gaojude commented Feb 13, 2025

ensure test files are populated in next deploy #76026

ensure test files are populated in next deploy #76026

Conversation

gaojude commented Feb 13, 2025 • edited Loading

gaojude commented Feb 13, 2025

ijjk commented Feb 13, 2025 • edited Loading

Failing test suites

ijjk commented Feb 13, 2025

Stats from current PR

gaojude commented Feb 13, 2025

gaojude commented Feb 13, 2025 •

edited

Loading

ijjk commented Feb 13, 2025 •

edited

Loading