Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] update overlay toolbar icons #75998

Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 13, 2025

Updated the Node.js inspector icon and the sizes of icons from 16 to 14.

Enabled Disabled
Light CleanShot 2025-02-14 at 00 45 20 CleanShot 2025-02-14 at 00 45 43
Dark CleanShot 2025-02-14 at 00 45 13 CleanShot 2025-02-14 at 00 45 48

Closes NDX-642

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 13, 2025
Copy link
Member Author

devjiwonchoi commented Feb 13, 2025

@ijjk
Copy link
Member

ijjk commented Feb 13, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 13, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
buildDuration 19.7s 18.1s N/A
buildDurationCached 17.3s 14.5s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +118 kB
nextStartRea..uration (ms) 459ms 460ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
5306-HASH.js gzip 55.1 kB 55.1 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 2.12 kB 2.12 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
index.html gzip 522 B 521 B N/A
link.html gzip 539 B 534 B N/A
withRouter.html gzip 519 B 516 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
middleware-b..fest.js gzip 675 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
app-page-exp...dev.js gzip 394 kB 395 kB ⚠️ +563 B
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB ⚠️ +584 B
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 1.68 MB 1.68 MB ⚠️ +1.15 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-13-_dev-overlay_update_nodejs_inspector_icon Change
0.pack gzip 2.11 MB 2.12 MB ⚠️ +1.19 kB
index.pack gzip 76.4 kB 76.5 kB N/A
Overall change 2.11 MB 2.12 MB ⚠️ +1.19 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 9e19ab7

@devjiwonchoi devjiwonchoi changed the title [dev-overlay] update nodejs inspector icon [dev-overlay] update overlay toolbar icons Feb 13, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 13, 2025 15:50
@devjiwonchoi devjiwonchoi force-pushed the 02-13-_dev-overlay_update_nodejs_inspector_icon branch from 73cdf9d to 4037c59 Compare February 13, 2025 16:37
@devjiwonchoi devjiwonchoi force-pushed the 02-12-_dev-overlay_sync_style_diffs_with_new_design branch from 6dcbb4f to 155e2f4 Compare February 13, 2025 16:37
Copy link
Member Author

devjiwonchoi commented Feb 13, 2025

Merge activity

  • Feb 13, 12:19 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 13, 12:21 PM EST: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@devjiwonchoi devjiwonchoi changed the base branch from 02-12-_dev-overlay_sync_style_diffs_with_new_design to graphite-base/75998 February 13, 2025 17:20
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/75998 to canary February 13, 2025 17:20
@devjiwonchoi devjiwonchoi force-pushed the 02-13-_dev-overlay_update_nodejs_inspector_icon branch from 4037c59 to 9e19ab7 Compare February 13, 2025 17:23
@devjiwonchoi devjiwonchoi merged commit a2f52ed into canary Feb 13, 2025
131 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-13-_dev-overlay_update_nodejs_inspector_icon branch February 13, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants