Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error overlay] fix infinite loop when frames are failed to fetch #75988

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 13, 2025

What

If the request of fetching for stack frames is failing, then it will throw error in dialog but no more extra catching. We should fallback to empty response and log the error

Closes NDX-816
Closes #75922

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 13, 2025
Copy link
Member Author

huozhi commented Feb 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@huozhi huozhi marked this pull request as ready for review February 13, 2025 00:08
@ijjk
Copy link
Member

ijjk commented Feb 13, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
buildDuration 19.6s 16.8s N/A
buildDurationCached 15.9s 13.4s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +3.62 kB
nextStartRea..uration (ms) 422ms 433ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
5306-HASH.js gzip 55.1 kB 55.1 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 2.12 kB 2.12 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
index.html gzip 522 B 521 B N/A
link.html gzip 539 B 534 B N/A
withRouter.html gzip 519 B 516 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
middleware-b..fest.js gzip 676 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
app-page-exp...dev.js gzip 394 kB 394 kB N/A
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB N/A
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 900 kB 900 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/02-13-fix_infinite_loop_in_error_overlay Change
0.pack gzip 2.11 MB 2.12 MB ⚠️ +3.21 kB
index.pack gzip 76.8 kB 76.8 kB N/A
Overall change 2.11 MB 2.12 MB ⚠️ +3.21 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: a85be4c

@huozhi huozhi enabled auto-merge (squash) February 13, 2025 00:28
@huozhi huozhi merged commit 3434df9 into canary Feb 13, 2025
131 checks passed
@huozhi huozhi deleted the huozhi/02-13-fix_infinite_loop_in_error_overlay branch February 13, 2025 00:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants