Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to nightly-2025-02-12 #75983

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Feb 12, 2025

This updates the Rust toolchain to nightly-2025-02-12. It required:

  • Removing #![feature(async_closure)]
  • Removing #![feature(map_many_mut)] and renaming map.get_many_mut() to map.get_disjoint_mut()
  • Adding a range argument to vec.extract_if()

Test Plan: CI

Closes PACK-3958

This updates the Rust toolchain to nightly-2025-02-12. It required:

- Removing `#![feature(async_closure)]`
- Removing `#![feature(map_many_mut)]` and renaming `map.get_many_mut()` to `map.get_disjoint_mut()`
- Adding a range argument to `vec.extract_if()`

Test Plan: CI
@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 12, 2025
@wbinnssmith wbinnssmith requested review from bgw and kdy1 February 12, 2025 21:38
@wbinnssmith
Copy link
Member Author

cc @vercel/turbopack

@ijjk
Copy link
Member

ijjk commented Feb 12, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
buildDuration 27.1s 23.9s N/A
buildDurationCached 21.7s 18.5s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 639ms 663ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
5306-HASH.js gzip 55.1 kB 55.1 kB N/A
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 2.12 kB 2.12 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
index.html gzip 522 B 521 B N/A
link.html gzip 539 B 534 B N/A
withRouter.html gzip 519 B 516 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
middleware-b..fest.js gzip 676 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
app-page-exp...dev.js gzip 394 kB 394 kB
app-page-exp..prod.js gzip 133 kB 133 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 25.5 kB 25.5 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB
Overall change 1.68 MB 1.68 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js wbinnssmith/toolchain-nightly-2025-02-12 Change
0.pack gzip 2.11 MB 2.12 MB ⚠️ +3.54 kB
index.pack gzip 77.2 kB 77 kB N/A
Overall change 2.11 MB 2.12 MB ⚠️ +3.54 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: e3d186e

@mischnic mischnic self-requested a review February 12, 2025 22:22
@ijjk
Copy link
Member

ijjk commented Feb 12, 2025

Failing test suites

Commit: e3d186e

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

  • persistent-caching > should persistent cache loaders
Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1739413997781"
Received: "Timestamp = 1739414018544"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

pnpm test-start-turbo test/e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts (turbopack)

  • segment cache (basic tests) > navigate before any data has loaded into the prefetch cache
Expand output

● segment cache (basic tests) › navigate before any data has loaded into the prefetch cache

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  13 |   }
  14 |
> 15 |   it('navigate before any data has loaded into the prefetch cache', async () => {
     |   ^
  16 |     let act: ReturnType<typeof createRouterAct>
  17 |     const browser = await next.browser('/', {
  18 |       beforePageLoad(page: Playwright.Page) {

  at it (e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts:15:3)
  at Object.describe (e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts:5:1)

Read more about building and testing Next.js in contributing.md.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/toolchain-nightly-2025-02-12 branch from 6455cb4 to addecc4 Compare February 13, 2025 01:35
@wbinnssmith wbinnssmith enabled auto-merge (squash) February 13, 2025 02:52
@wbinnssmith wbinnssmith merged commit cb8d1b0 into canary Feb 13, 2025
130 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/toolchain-nightly-2025-02-12 branch February 13, 2025 03:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants