Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix recomputation when reading gc'ed cells from in progress tasks #75969

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix recomputation when reading gc'ed cells from in progress tasks #75969

merged 2 commits into from
Feb 14, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 12, 2025 •
edited by padmaia
Loading

Closes PACK-3970

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 12, 2025
@sokra sokra mentioned this pull request Feb 12, 2025
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Feb 12, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Feb 12, 2025
Merged
@ijjk
Copy link
Member

ijjk commented Feb 12, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
buildDuration 22.6s 20.7s N/A
buildDurationCached 19.2s 16.4s N/A
nodeModulesSize 393 MB 393 MB ✓
nextStartRea..uration (ms) 528ms 519ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
5306-HASH.js gzip 55.1 kB 55.1 kB N/A
7048.HASH.js gzip 168 B 168 B ✓
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B ✓
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB ✓
Overall change 2.12 kB 2.12 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B ✓
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB ✓
routerDirect..HASH.js gzip 327 B 326 B N/A
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 325 B 325 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.72 kB 3.72 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
index.html gzip 522 B 521 B N/A
link.html gzip 539 B 534 B N/A
withRouter.html gzip 519 B 516 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
middleware-b..fest.js gzip 676 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.4 kB 31.4 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
app-page-exp...dev.js gzip 394 kB 394 kB ✓
app-page-exp..prod.js gzip 133 kB 133 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 382 kB 382 kB ✓
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.4 kB 39.4 kB ✓
app-route-ex..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route.ru...dev.js gzip 41 kB 41 kB ✓
app-route.ru..prod.js gzip 25.5 kB 25.5 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 31.6 kB 31.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 61.2 kB 61.2 kB ✓
Overall change 1.68 MB 1.68 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/recompute-cell-in-progress Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 75.2 kB 75.9 kB ⚠️ +673 B
Overall change 75.2 kB 75.9 kB ⚠️ +673 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 7bbc350

@ijjk
Copy link
Member

ijjk commented Feb 12, 2025 •
edited
Loading

Tests Passed

@sokra sokra requested a review from mischnic February 12, 2025 20:02
@sokra sokra marked this pull request as ready for review February 12, 2025 20:03
@timneutkens timneutkens force-pushed the sokra/recompute-cell-in-progress branch from 72141e2 to 26859cf Compare February 13, 2025 12:32
@sokra sokra force-pushed the sokra/recompute-cell-in-progress branch from 26859cf to 7bbc350 Compare February 13, 2025 12:41
sokra
sokra commented Feb 13, 2025
View reviewed changes
turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
if !*stale {
let idx = get!(
task,
CellTypeMaxIndex {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In progress tasks are never gced and have their counts in task locals anyway

@sokra sokra marked this pull request as draft February 14, 2025 05:12
@timneutkens timneutkens marked this pull request as ready for review February 14, 2025 10:34
@timneutkens timneutkens merged commit 2cd905c into canary Feb 14, 2025
131 checks passed
@timneutkens timneutkens deleted the sokra/recompute-cell-in-progress branch February 14, 2025 10:43
devjiwonchoi pushed a commit that referenced this pull request Feb 14, 2025
@sokra @devjiwonchoi
fix recomputation when reading gc'ed cells from in progress tasks (#7…
d353523 
…5969)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sokra @ijjk @mischnic @timneutkens