-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sourcemap tests due to recent Turbopack changes #75954
Update sourcemap tests due to recent Turbopack changes #75954
Conversation
Failing test suitesCommit: 15309a6
Expand output● ReactRefreshLogBox turbo › render error not shown right after syntax error
Read more about building and testing Next.js in contributing.md. |
'\n at runWithExternalSourceMapped (app/ssr-error-log-ignore-listed/page.js:18:29)' + | ||
'\n at runWithExternal (app/ssr-error-log-ignore-listed/page.js:17:32)' + | ||
'\n at runWithInternalSourceMapped (app/ssr-error-log-ignore-listed/page.js:16:18)' + | ||
// Realpath does not point into node_modules so we don't ignore it. | ||
'\n at runInternalSourceMapped (internal-pkg/sourcemapped.ts:5:9)' + | ||
// TODO(veil): Should be internal-pkg/sourcemapped.ts | ||
'\n at runInternalSourceMapped (sourcemapped.ts:5:9)' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a regression. The sourcemap contains sourcemapped.ts
in sources
. This should be handled as a relative URL: new URL("sourcemapped.ts", "file:///internal-pkg/sourcemapped.js").href === 'file:///internal-pkg/sourcemapped.ts'
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
buildDuration | 21.6s | 19.5s | N/A |
buildDurationCached | 18.7s | 16s | N/A |
nodeModulesSize | 393 MB | 393 MB | ✓ |
nextStartRea..uration (ms) | 492ms | 481ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
5306-HASH.js gzip | 55 kB | 55 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.47 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 245 B | 246 B | N/A |
main-HASH.js gzip | 34.7 kB | 34.7 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.59 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 748 B | ✓ |
Overall change | 748 B | 748 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 538 B | 538 B | ✓ |
withRouter.html gzip | 520 B | 520 B | ✓ |
Overall change | 1.58 kB | 1.58 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
edge-ssr.js gzip | 130 kB | 130 kB | N/A |
page.js gzip | 211 kB | 211 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 676 B | 671 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 394 kB | 394 kB | ✓ |
app-page-exp..prod.js gzip | 132 kB | 132 kB | ✓ |
app-page-tur..prod.js gzip | 145 kB | 145 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page.run...dev.js gzip | 382 kB | 382 kB | ✓ |
app-page.run..prod.js gzip | 129 kB | 129 kB | ✓ |
app-route-ex...dev.js gzip | 39.3 kB | 39.3 kB | ✓ |
app-route-ex..prod.js gzip | 25.7 kB | 25.7 kB | ✓ |
app-route-tu..prod.js gzip | 25.7 kB | 25.7 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 40.9 kB | 40.9 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
dist_client_...dev.js gzip | 356 B | 356 B | ✓ |
dist_client_...dev.js gzip | 349 B | 349 B | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.8 kB | 11.8 kB | ✓ |
pages-api.ru..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-turbo...prod.js gzip | 22 kB | 22 kB | ✓ |
pages.runtim...dev.js gzip | 31.6 kB | 31.6 kB | ✓ |
pages.runtim..prod.js gzip | 22 kB | 22 kB | ✓ |
server.runti..prod.js gzip | 61.1 kB | 61.1 kB | ✓ |
Overall change | 1.67 MB | 1.67 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js sebbie/02-12-update_sourcemap_tests_due_to_recent_turbopack_changes | Change | |
---|---|---|---|
0.pack gzip | 2.11 MB | 2.11 MB | |
index.pack gzip | 76 kB | 75.8 kB | N/A |
Overall change | 2.11 MB | 2.11 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
e347899
to
15309a6
Compare
Caused by a stale merge of #75907 without being based on #75791.
#75791 fixed a bug with
ignoreList
not being loaded but also introduced a new regression where sources are not treated as relative URLs.