[dev-overlay] sync style diffs with new design #75949

devjiwonchoi · 2025-02-12T08:07:34Z

This PR synced style with the re-redesign.

Before	After

Closes NDX-811

devjiwonchoi · 2025-02-12T08:07:52Z

[dev-overlay] add error env name label #76003
[dev-overlay] update overlay toolbar icons #75998
[dev-overlay] sync style diffs with new design #75949 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-12T08:12:24Z

Tests Passed

ijjk · 2025-02-12T08:14:40Z

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
buildDuration	20.8s	16.9s	N/A
buildDurationCached	16.1s	13.4s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	426ms	444ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
5306-HASH.js gzip	55.1 kB	55.1 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.7 kB	34.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	2.12 kB	2.12 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	327 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
index.html gzip	522 B	521 B	N/A
link.html gzip	539 B	534 B	N/A
withRouter.html gzip	519 B	516 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
middleware-b..fest.js gzip	676 B	672 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.4 kB	31.4 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
app-page-exp...dev.js gzip	394 kB	394 kB	N/A
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	382 kB	382 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	41 kB	41 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	900 kB	900 kB	✓

build cache

	vercel/next.js canary	vercel/next.js 02-12-_dev-overlay_sync_style_diffs_with_new_design	Change
0.pack gzip	2.12 MB	2.11 MB	N/A
index.pack gzip	77.3 kB	75.6 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 7284fb1

...t/src/client/components/react-dev-overlay/_experimental/internal/components/dialog/styles.ts

huozhi · 2025-02-13T12:32:31Z

test/development/app-dir/dev-overlay/build-error/terminal-pre-wrap.test.ts

+    const browser = await next.browser('/')
+    const computedStyle = await browser.eval(
+      (element) => {
+        return window.getComputedStyle(element).whiteSpace


maybe just me, feel it's bit heavy to test out certain styles with e2e tests. I think we can ship the visual changes with screenshot showing what changed and figure out a better way to test this later. As I feel we might need a light way to do it, or we can assert along with other errors.

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

huozhi

can you add a screenshot comparison

devjiwonchoi · 2025-02-13T17:19:49Z

Merge activity

Feb 13, 12:19 PM EST: A user started a stack merge that includes this pull request via Graphite.
Feb 13, 12:20 PM EST: A user merged this pull request with Graphite.

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 12, 2025

devjiwonchoi force-pushed the 02-12-_dev-overlay_sync_style_diffs_with_new_design branch from 4a69de7 to 8de58eb Compare February 13, 2025 06:37

ijjk added the tests label Feb 13, 2025

devjiwonchoi marked this pull request as ready for review February 13, 2025 09:09

devjiwonchoi requested review from ztanner, huozhi, eps1lon and gaojude February 13, 2025 09:10

devjiwonchoi mentioned this pull request Feb 13, 2025

[dev-overlay] update overlay toolbar icons #75998

Merged

huozhi reviewed Feb 13, 2025

View reviewed changes

devjiwonchoi mentioned this pull request Feb 13, 2025

[dev-overlay] add error env name label #76003

Merged

[dev-overlay] sync style diffs with new design

155e2f4

devjiwonchoi force-pushed the 02-12-_dev-overlay_sync_style_diffs_with_new_design branch from 6dcbb4f to 155e2f4 Compare February 13, 2025 16:37

devjiwonchoi and others added 2 commits February 14, 2025 01:38

remove testing

8fcfa25

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

use css var

7284fb1

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

devjiwonchoi requested a review from huozhi February 13, 2025 16:39

huozhi reviewed Feb 13, 2025

View reviewed changes

devjiwonchoi requested a review from huozhi February 13, 2025 16:46

huozhi approved these changes Feb 13, 2025

View reviewed changes

devjiwonchoi merged commit f20f389 into canary Feb 13, 2025
134 checks passed

devjiwonchoi deleted the 02-12-_dev-overlay_sync_style_diffs_with_new_design branch February 13, 2025 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev-overlay] sync style diffs with new design #75949

[dev-overlay] sync style diffs with new design #75949

devjiwonchoi commented Feb 12, 2025 •

edited

Loading

devjiwonchoi commented Feb 12, 2025 •

edited

Loading

ijjk commented Feb 12, 2025 •

edited

Loading

ijjk commented Feb 12, 2025 •

edited

Loading

huozhi Feb 13, 2025

devjiwonchoi Feb 13, 2025

huozhi left a comment

devjiwonchoi commented Feb 13, 2025 •

edited

Loading

[dev-overlay] sync style diffs with new design #75949

[dev-overlay] sync style diffs with new design #75949

Conversation

devjiwonchoi commented Feb 12, 2025 • edited Loading

devjiwonchoi commented Feb 12, 2025 • edited Loading

ijjk commented Feb 12, 2025 • edited Loading

Tests Passed

ijjk commented Feb 12, 2025 • edited Loading

Stats from current PR

huozhi Feb 13, 2025

Choose a reason for hiding this comment

devjiwonchoi Feb 13, 2025

Choose a reason for hiding this comment

huozhi left a comment

Choose a reason for hiding this comment

devjiwonchoi commented Feb 13, 2025 • edited Loading

Merge activity

devjiwonchoi commented Feb 12, 2025 •

edited

Loading

devjiwonchoi commented Feb 12, 2025 •

edited

Loading

ijjk commented Feb 12, 2025 •

edited

Loading

ijjk commented Feb 12, 2025 •

edited

Loading

devjiwonchoi commented Feb 13, 2025 •

edited

Loading