Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for missing sourcemap loader support of ignoreList #75907

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 11, 2025

Neither Webpack nor Turbopack preserve this property. Webpack is even worse because the original source URLs are malformed.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Feb 11, 2025
Copy link
Member Author

eps1lon commented Feb 11, 2025

@ijjk
Copy link
Member

ijjk commented Feb 11, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
buildDuration 18.5s 16.8s N/A
buildDurationCached 16s 13.5s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 442ms 437ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
5306-HASH.js gzip 54.8 kB 54.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
index.html gzip 524 B 524 B
link.html gzip 540 B 537 B N/A
withRouter.html gzip 521 B 520 B N/A
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
middleware-b..fest.js gzip 673 B 673 B
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 1.52 kB 1.52 kB
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 61 kB 61 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ Change
0.pack gzip 2.11 MB 2.11 MB N/A
index.pack gzip 75.2 kB 76.1 kB ⚠️ +924 B
Overall change 75.2 kB 76.1 kB ⚠️ +924 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 47c5a9a

@eps1lon eps1lon changed the base branch from sebbie/02-11-test_write_files_before_install to graphite-base/75907 February 11, 2025 14:50
@eps1lon eps1lon force-pushed the sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ branch from 25549b9 to f8a4ea6 Compare February 11, 2025 14:58
@eps1lon eps1lon force-pushed the graphite-base/75907 branch from 498ea04 to 058f0b7 Compare February 11, 2025 14:58
@ijjk
Copy link
Member

ijjk commented Feb 11, 2025

Tests Passed

@eps1lon eps1lon marked this pull request as ready for review February 11, 2025 16:28
@eps1lon eps1lon requested a review from gaojude February 11, 2025 16:29
Copy link
Member Author

eps1lon commented Feb 11, 2025

Merge activity

  • Feb 11, 8:06 PM GMT+1: A user started a stack merge that includes this pull request via Graphite.
  • Feb 11, 8:08 PM GMT+1: Graphite rebased this pull request as part of a merge.
  • Feb 11, 8:26 PM GMT+1: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'test unit (18) / build').
  • Feb 12, 9:13 AM GMT+1: A user merged this pull request with Graphite.

@eps1lon eps1lon changed the base branch from graphite-base/75907 to canary February 11, 2025 19:06
@eps1lon eps1lon force-pushed the sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ branch from f8a4ea6 to 47c5a9a Compare February 11, 2025 19:07
@eps1lon eps1lon merged commit a71a764 into canary Feb 12, 2025
131 checks passed
@eps1lon eps1lon deleted the sebbie/02-11-add_test_for_missing_sourcemap_loader_support_of_ignorelist_ branch February 12, 2025 08:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants