test: Write files before install #75906

eps1lon · 2025-02-11T13:54:15Z

That way we can install packages that are local to the install (e.g. via link: or file: protocol).

Before, we had to reference the packages in the Next.js monorepo. This wouldn't allow simulating the install dir as a classic monorepo.

eps1lon · 2025-02-11T13:54:33Z

Add test for missing sourcemap loader support of ignoreList #75907
test: Write files before install #75906 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-11T14:04:00Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
buildDuration	19.9s	21.2s	⚠️ +1.3s
buildDurationCached	17.3s	14.6s	N/A
nodeModulesSize	393 MB	393 MB	⚠️ +67.4 kB
nextStartRea..uration (ms)	468ms	449ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
5306-HASH.js gzip	54.8 kB	54.3 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.6 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	245 B	245 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	521 B	N/A
Overall change	524 B	524 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
middleware-b..fest.js gzip	676 B	670 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
app-page-exp...dev.js gzip	393 kB	394 kB	⚠️ +526 B
app-page-exp..prod.js gzip	132 kB	132 kB	N/A
app-page-tur..prod.js gzip	145 kB	145 kB	N/A
app-page-tur..prod.js gzip	141 kB	141 kB	N/A
app-page.run...dev.js gzip	381 kB	381 kB	⚠️ +436 B
app-page.run..prod.js gzip	129 kB	129 kB	N/A
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	N/A
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	N/A
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	N/A
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	N/A
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	61 kB	60.7 kB	N/A
Overall change	881 kB	882 kB	⚠️ +962 B

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-11-test_write_files_before_install	Change
0.pack gzip	2.11 MB	2.11 MB	⚠️ +568 B
index.pack gzip	75.4 kB	75.2 kB	N/A
Overall change	2.11 MB	2.11 MB	⚠️ +568 B

Diff details

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 5306-HASH.js

Diff too large to display

Diff for bccd1874-HASH.js

@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
-  [7629],
+  [1758],
   {
-    /***/ 641: /***/ (
+    /***/ 8699: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
     ) => {
-      /* provided dependency */ var process = __webpack_require__(6611);
+      /* provided dependency */ var process = __webpack_require__(9829);
       /**
        * @license React
        * react-dom-client.production.js
@@ -22,9 +22,9 @@
  Modernizr 3.0.0pre (Custom Build) | MIT
 */
 
-      var Scheduler = __webpack_require__(8684),
-        React = __webpack_require__(1446),
-        ReactDOM = __webpack_require__(8307);
+      var Scheduler = __webpack_require__(462),
+        React = __webpack_require__(228),
+        ReactDOM = __webpack_require__(9221);
       function formatProdErrorMessage(code) {
         var url = "https://react.dev/errors/" + code;
         if (1 < arguments.length) {
@@ -14705,8 +14705,6 @@
       function getHoistableRoot(container) {
         return "function" === typeof container.getRootNode
           ? container.getRootNode()
-          : 9 === container.nodeType
-          ? container
           : container.ownerDocument;
       }
       var previousDispatcher = ReactDOMSharedInternals.d;
@@ -16253,14 +16251,14 @@
       };
       var isomorphicReactPackageVersion$jscomp$inline_1754 = React.version;
       if (
-        "19.1.0-canary-93b58361-20250209" !==
+        "19.1.0-canary-ff628334-20250205" !==
         isomorphicReactPackageVersion$jscomp$inline_1754
       )
         throw Error(
           formatProdErrorMessage(
             527,
             isomorphicReactPackageVersion$jscomp$inline_1754,
-            "19.1.0-canary-93b58361-20250209"
+            "19.1.0-canary-ff628334-20250205"
           )
         );
       ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16282,10 +16280,10 @@
       };
       var internals$jscomp$inline_2235 = {
         bundleType: 0,
-        version: "19.1.0-canary-93b58361-20250209",
+        version: "19.1.0-canary-ff628334-20250205",
         rendererPackageName: "react-dom",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.1.0-canary-93b58361-20250209",
+        reconcilerVersion: "19.1.0-canary-ff628334-20250205",
       };
       if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
         var hook$jscomp$inline_2236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16393,7 +16391,7 @@
         listenToAllSupportedEvents(container);
         return new ReactDOMHydrationRoot(initialChildren);
       };
-      exports.version = "19.1.0-canary-93b58361-20250209";
+      exports.version = "19.1.0-canary-ff628334-20250205";
 
       /***/
     },

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

failed to diff

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 058f0b7

That way we can install packages that are local to the install (e.g. via `link:` or `file:`` protocol). Before, we had to reference the packages in the Next.js monorepo. This wouldn't allow simulating the install dir as a classic monorepo.

eps1lon · 2025-02-11T19:06:02Z

Merge activity

Feb 11, 8:06 PM GMT+1: A user started a stack merge that includes this pull request via Graphite.
Feb 11, 8:06 PM GMT+1: A user merged this pull request with Graphite.

ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Feb 11, 2025

eps1lon mentioned this pull request Feb 11, 2025

Add test for missing sourcemap loader support of ignoreList #75907

Merged

test: Write files before install

058f0b7

That way we can install packages that are local to the install (e.g. via `link:` or `file:`` protocol). Before, we had to reference the packages in the Next.js monorepo. This wouldn't allow simulating the install dir as a classic monorepo.

eps1lon force-pushed the sebbie/02-11-test_write_files_before_install branch from 498ea04 to 058f0b7 Compare February 11, 2025 14:50

eps1lon marked this pull request as ready for review February 11, 2025 16:28

eps1lon requested a review from gaojude February 11, 2025 16:29

gaojude approved these changes Feb 11, 2025

View reviewed changes

eps1lon merged commit 412d6fe into canary Feb 11, 2025
143 checks passed

eps1lon deleted the sebbie/02-11-test_write_files_before_install branch February 11, 2025 19:06

gaojude mentioned this pull request Feb 13, 2025

ensure test files are populated in next deploy #76026

Closed

github-actions bot added the locked label Feb 26, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Write files before install #75906

test: Write files before install #75906

eps1lon commented Feb 11, 2025 •

edited

Loading

eps1lon commented Feb 11, 2025

ijjk commented Feb 11, 2025 •

edited

Loading

eps1lon commented Feb 11, 2025 •

edited

Loading

test: Write files before install #75906

test: Write files before install #75906

Conversation

eps1lon commented Feb 11, 2025 • edited Loading

eps1lon commented Feb 11, 2025

ijjk commented Feb 11, 2025 • edited Loading

Stats from current PR

eps1lon commented Feb 11, 2025 • edited Loading

Merge activity

eps1lon commented Feb 11, 2025 •

edited

Loading

ijjk commented Feb 11, 2025 •

edited

Loading

eps1lon commented Feb 11, 2025 •

edited

Loading