Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webpack-config): Disable some options based on bundler version #75888

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Feb 11, 2025

Extracted from the try-ci-test work: #75443

Includes some minor cleanup, deduping some use of the environment variable.

Copy link
Member Author

bgw commented Feb 11, 2025

@bgw bgw requested review from ijjk and wbinnssmith February 11, 2025 00:26
@bgw bgw marked this pull request as ready for review February 11, 2025 00:26
@ijjk
Copy link
Member

ijjk commented Feb 11, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
buildDuration 28.1s 21.6s N/A
buildDurationCached 20.4s 17.8s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +10.2 kB
nextStartRea..uration (ms) 522ms 528ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
5306-HASH.js gzip 54.3 kB 54.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
middleware-b..fest.js gzip 675 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
app-page-exp...dev.js gzip 395 kB 395 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.7 kB 60.7 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/bundler-disable-features Change
0.pack gzip 2.11 MB 2.11 MB ⚠️ +1.49 kB
index.pack gzip 76.4 kB 77.1 kB ⚠️ +681 B
Overall change 2.19 MB 2.19 MB ⚠️ +2.17 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 993dc1b

@ijjk
Copy link
Member

ijjk commented Feb 11, 2025

Tests Passed

@bgw bgw changed the base branch from bgw/js-config-path to graphite-base/75888 February 11, 2025 03:53
@bgw bgw force-pushed the bgw/bundler-disable-features branch from b9ee49f to 0606df3 Compare February 11, 2025 03:54
@bgw bgw force-pushed the graphite-base/75888 branch from feb6396 to c3543f8 Compare February 11, 2025 03:54
@bgw bgw changed the base branch from graphite-base/75888 to canary February 11, 2025 03:54
@bgw bgw force-pushed the bgw/bundler-disable-features branch from 0606df3 to 993dc1b Compare February 11, 2025 03:54
@bgw bgw merged commit 95c3522 into canary Feb 11, 2025
131 checks passed
Copy link
Member Author

bgw commented Feb 11, 2025

Merge activity

  • Feb 11, 1:32 AM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/bundler-disable-features branch February 11, 2025 06:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants