Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] Add final_read_hint API and change clone_value to owned #75852

Merged
merged 5 commits into from
Feb 11, 2025
Merged

[Turbopack] Add final_read_hint API and change clone_value to owned #75852

merged 5 commits into from
Feb 11, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 10, 2025 •
edited by padmaia
Loading

What?

  • add ReadCellOptions to cell reads
  • refactor read future api and add final_read_hint
  • add ReadRef::try_unwrap, .owned
  • remove .clone_value
  • remove cell on final_read_hint

Closes PACK-3938

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 10, 2025
@sokra sokra mentioned this pull request Feb 10, 2025
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Feb 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Feb 10, 2025
Merged
@ijjk
Copy link
Member

ijjk commented Feb 10, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 10, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/take-cell Change
buildDuration 20s 18.4s N/A
buildDurationCached 17.4s 15s N/A
nodeModulesSize 393 MB 393 MB ✓
nextStartRea..uration (ms) 470ms 484ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/take-cell Change
5306-HASH.js gzip 54.3 kB 54.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/take-cell Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/take-cell Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/take-cell Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/take-cell Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 520 B 520 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/take-cell Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/take-cell Change
middleware-b..fest.js gzip 677 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/take-cell Change
app-page-exp...dev.js gzip 395 kB 395 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 382 kB 382 kB ✓
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.9 kB 40.9 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.7 kB 60.7 kB ✓
Overall change 1.67 MB 1.67 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/take-cell Change
0.pack gzip 2.11 MB 2.11 MB N/A
index.pack gzip 75.9 kB 76.6 kB ⚠️ +787 B
Overall change 75.9 kB 76.6 kB ⚠️ +787 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 56d3714

@sokra sokra mentioned this pull request Feb 10, 2025
Merged
@sokra sokra requested a review from mischnic February 10, 2025 09:42
@sokra sokra changed the title add ReadCellOptions to cell reads [Turbopack] Add final_read_hint API and change clone_value to owned Feb 10, 2025
@sokra sokra marked this pull request as ready for review February 10, 2025 09:43
@sokra sokra force-pushed the sokra/no-parse-cache-in-prod branch from ddbf160 to 0378b34 Compare February 11, 2025 07:46
@sokra sokra force-pushed the sokra/no-parse-cache-in-prod branch 2 times, most recently from ef3dc75 to 52a0636 Compare February 11, 2025 08:10
@sokra sokra mentioned this pull request Feb 11, 2025
Open
This was referenced Feb 11, 2025
Merged
Merged
@sokra sokra changed the base branch from sokra/no-parse-cache-in-prod to sokra/fix-active-counting-hanging February 11, 2025 08:45
@sokra sokra force-pushed the sokra/fix-active-counting-hanging branch 2 times, most recently from 5057314 to 4bc9ed3 Compare February 11, 2025 08:56
@sokra sokra changed the base branch from sokra/fix-active-counting-hanging to graphite-base/75852 February 11, 2025 09:24
@sokra sokra changed the base branch from graphite-base/75852 to canary February 11, 2025 09:25
@sokra sokra merged commit 69bf830 into canary Feb 11, 2025
131 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Feb 11, 2025

Merge activity

  • Feb 11, 12:14 PM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/take-cell branch February 11, 2025 17:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @mischnic