Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] fix recompute invalidation #75850

Merged
merged 5 commits into from
Feb 11, 2025
Merged

[Turbopack] fix recompute invalidation #75850

merged 5 commits into from
Feb 11, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 10, 2025

What?

  • add tracing to recomputation
  • fix recomputation hanging in a loop (reexecution should not invalidate recomputed cells, even if they still have content and Eq says they are not equal. Some value types does implement Eq as always false, e. g. the AST)

Closes PACK-3930

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 10, 2025
Copy link
Member Author

sokra commented Feb 10, 2025

@ijjk
Copy link
Member

ijjk commented Feb 10, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 10, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
buildDuration 32.4s 16.7s N/A
buildDurationCached 16s 13.3s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 436ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
5306-HASH.js gzip 54.3 kB 54.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
middleware-b..fest.js gzip 676 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
app-page-exp...dev.js gzip 395 kB 395 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.7 kB 60.7 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-recompute Change
0.pack gzip 2.11 MB 2.11 MB N/A
index.pack gzip 75.3 kB 77.1 kB ⚠️ +1.76 kB
Overall change 75.3 kB 77.1 kB ⚠️ +1.76 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 5dee839

@sokra sokra requested a review from mischnic February 10, 2025 09:37
@sokra sokra marked this pull request as ready for review February 10, 2025 09:38
@sokra sokra changed the title fix recompute invalidation [Turbopack] fix recompute invalidation Feb 10, 2025
@sokra sokra force-pushed the sokra/fix-recompute branch from 9923631 to 5dee839 Compare February 11, 2025 07:46
@sokra sokra merged commit 203fa9f into canary Feb 11, 2025
131 checks passed
Copy link
Member Author

sokra commented Feb 11, 2025

Merge activity

  • Feb 11, 3:09 AM EST: A user merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants