Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for visibility not just existence of Redbox #75846

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Check for visibility not just existence of Redbox #75846

merged 1 commit into from
Feb 13, 2025

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 9, 2025 •
edited by devjiwonchoi
Loading

This ensures that we don't just use some opacity hacks to hide it. opacity: 0 isn't sufficient because the container would still be accessible.

Closes NDX-582

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Feb 9, 2025
@eps1lon Graphite App
Copy link
Member Author

eps1lon commented Feb 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Feb 9, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 9, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
buildDuration 19.8s 16.7s N/A
buildDurationCached 15.8s 13.3s N/A
nodeModulesSize 393 MB 393 MB ✓
nextStartRea..uration (ms) 432ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
5306-HASH.js gzip 55 kB 55 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.47 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 243 B N/A
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
_buildManifest.js gzip 748 B 748 B ✓
Overall change 748 B 748 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 520 B 520 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
middleware-b..fest.js gzip 676 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
app-page-exp...dev.js gzip 394 kB 394 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 382 kB 382 kB ✓
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.7 kB 25.7 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.9 kB 40.9 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.69 kB 9.69 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 31.6 kB 31.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 61.1 kB 61.1 kB ✓
Overall change 1.67 MB 1.67 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/02-10-check_for_visibility_not_just_existence_of_redbox Change
0.pack gzip 2.11 MB 2.11 MB N/A
index.pack gzip 75 kB 76.4 kB ⚠️ +1.39 kB
Overall change 75 kB 76.4 kB ⚠️ +1.39 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: b19aafc

@eps1lon eps1lon force-pushed the sebbie/02-10-check_for_visibility_not_just_existence_of_redbox branch from 4256cad to f555f28 Compare February 12, 2025 12:24
@eps1lon eps1lon force-pushed the sebbie/02-10-check_for_visibility_not_just_existence_of_redbox branch from f555f28 to b19aafc Compare February 12, 2025 16:09
eps1lon
eps1lon commented Feb 12, 2025
View reviewed changes
test/lib/next-test-utils.ts
@@ -1036,8 +1023,6 @@ export async function getRedboxTotalErrorCount(
}

export async function getRedboxSource(browser: BrowserInterface) {
await ensureNoSuspendedComponentsInRedBox(browser)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contract is that you always call assertHasRedbox before which already waits for the suspended content.

eps1lon
eps1lon commented Feb 12, 2025
View reviewed changes
test/lib/browsers/playwright.ts
@@ -516,4 +517,10 @@ export class Playwright extends BrowserInterface {
return page.waitForLoadState('networkidle')
})
}

locateRedbox(): Locator {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be in next-test-utils but exposing the whole page object may be a bit early.

@eps1lon eps1lon marked this pull request as ready for review February 12, 2025 17:02
@eps1lon eps1lon merged commit 0466204 into canary Feb 13, 2025
133 checks passed
@eps1lon eps1lon deleted the sebbie/02-10-check_for_visibility_not_just_existence_of_redbox branch February 13, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaojude gaojude gaojude approved these changes

@devjiwonchoi devjiwonchoi devjiwonchoi approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @ijjk @gaojude @devjiwonchoi