[dev-overlay] fix: call stack silently fails to open editor with 204

[devjiwonchoi]

Why?

When fails to find the file to open in the editor, the middleware returned No Content with 204 status. This caused to silently fail the open editor behavior.

How?

• Added 404 not found state for when the target file does not exist.

Closes NDX-792

[devjiwonchoi]

• [dev-overlay] fix: call stack silently fails to open editor with 204 #75785 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
buildDuration	19.5s	18.8s	N/A
buildDurationCached	15.9s	13.1s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	433ms	435ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
5306-HASH.js gzip	54.8 kB	54.3 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.6 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	245 B	245 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	540 B	538 B	N/A
withRouter.html gzip	521 B	520 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
middleware-b..fest.js gzip	672 B	670 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
app-page-exp...dev.js gzip	394 kB	394 kB	N/A
app-page-exp..prod.js gzip	132 kB	132 kB	N/A
app-page-tur..prod.js gzip	145 kB	145 kB	N/A
app-page-tur..prod.js gzip	141 kB	141 kB	N/A
app-page.run...dev.js gzip	381 kB	381 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	N/A
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	N/A
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	N/A
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	N/A
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	N/A
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	N/A
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	61 kB	60.7 kB	N/A
Overall change	107 kB	107 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-07-_dev-overlay_fix_call_stack_silently_fails_to_open_editor_with_204	Change
0.pack gzip	2.11 MB	2.11 MB	⚠️ +3.37 kB
index.pack gzip	76.2 kB	75.9 kB	N/A
Overall change	2.11 MB	2.11 MB	⚠️ +3.37 kB

Diff details

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 5306-HASH.js

Diff too large to display

Diff for bccd1874-HASH.js

@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
-  [7629],
+  [1758],
   {
-    /***/ 641: /***/ (
+    /***/ 8699: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
     ) => {
-      /* provided dependency */ var process = __webpack_require__(6611);
+      /* provided dependency */ var process = __webpack_require__(9829);
       /**
        * @license React
        * react-dom-client.production.js
@@ -22,9 +22,9 @@
  Modernizr 3.0.0pre (Custom Build) | MIT
 */
 
-      var Scheduler = __webpack_require__(8684),
-        React = __webpack_require__(1446),
-        ReactDOM = __webpack_require__(8307);
+      var Scheduler = __webpack_require__(462),
+        React = __webpack_require__(228),
+        ReactDOM = __webpack_require__(9221);
       function formatProdErrorMessage(code) {
         var url = "https://react.dev/errors/" + code;
         if (1 < arguments.length) {
@@ -14705,8 +14705,6 @@
       function getHoistableRoot(container) {
         return "function" === typeof container.getRootNode
           ? container.getRootNode()
-          : 9 === container.nodeType
-          ? container
           : container.ownerDocument;
       }
       var previousDispatcher = ReactDOMSharedInternals.d;
@@ -16253,14 +16251,14 @@
       };
       var isomorphicReactPackageVersion$jscomp$inline_1754 = React.version;
       if (
-        "19.1.0-canary-93b58361-20250209" !==
+        "19.1.0-canary-ff628334-20250205" !==
         isomorphicReactPackageVersion$jscomp$inline_1754
       )
         throw Error(
           formatProdErrorMessage(
             527,
             isomorphicReactPackageVersion$jscomp$inline_1754,
-            "19.1.0-canary-93b58361-20250209"
+            "19.1.0-canary-ff628334-20250205"
           )
         );
       ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16282,10 +16280,10 @@
       };
       var internals$jscomp$inline_2235 = {
         bundleType: 0,
-        version: "19.1.0-canary-93b58361-20250209",
+        version: "19.1.0-canary-ff628334-20250205",
         rendererPackageName: "react-dom",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.1.0-canary-93b58361-20250209",
+        reconcilerVersion: "19.1.0-canary-ff628334-20250205",
       };
       if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
         var hook$jscomp$inline_2236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16393,7 +16391,7 @@
         listenToAllSupportedEvents(container);
         return new ReactDOMHydrationRoot(initialChildren);
       };
-      exports.version = "19.1.0-canary-93b58361-20250209";
+      exports.version = "19.1.0-canary-ff628334-20250205";
 
       /***/
     },

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

failed to diff

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: e940669

[ijjk]

Failing test suites

Commit: e940669

pnpm test test/integration/amp-export-validation/test/index.test.js (turbopack)

• AMP Validation on Export > production mode > should have shown errors during build

Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.2.0-canary.52 (Turbopack)·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Building (0/7) ...
   Building (1/7)··
   Building (3/7)··
   Building (5/7)··
 ✓ Building (7/7)
 ✓ Compiled successfully in 1826ms
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/first\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:106:1695)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:107:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:109:142)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2663:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:87:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:104:13)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:156:20)
  at async exportPage (../packages/next/dist/export/worker.js:358:18)
  Export encountered an error on /first, exiting the build.
   ⨯ Next.js build worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

[huozhi]

This changed the behavior. when res.ok is false now it will error in console and capture by error overlay, which won’t happen before because status 204 also matches ok.

framework DX error should not be surfaced in error dialog as users couldn't do anything.

I think it's fine to return 404 but we shouldn't log it into error overlay.