Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-overlay] style: version info staleness click text to learn more #75768

Merged
merged 3 commits into from
Feb 13, 2025
Merged

[dev-overlay] style: version info staleness click text to learn more #75768

merged 3 commits into from
Feb 13, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 6, 2025 •
edited
Loading

When the Next.js version is stale and revealing the docs for the version staleness, remove (learn more) and modify the info text to be clickable.

Light

CleanShot.2025-02-12.at.05.26.53.mp4

Dark

CleanShot.2025-02-12.at.05.26.24.mp4

Closes NDX-637

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 6, 2025
@devjiwonchoi Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 6, 2025 21:52
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 6, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
buildDuration 28.3s 23.9s N/A
buildDurationCached 23.5s 20.6s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +13.7 kB
nextStartRea..uration (ms) 752ms 759ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
5306-HASH.js gzip 54.8 kB 54.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
index.html gzip 524 B 524 B ✓
link.html gzip 540 B 537 B N/A
withRouter.html gzip 521 B 520 B N/A
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
middleware-b..fest.js gzip 672 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
app-page-exp...dev.js gzip 394 kB 394 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 381 kB 381 kB N/A
app-page.run..prod.js gzip 129 kB 129 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.9 kB 40.9 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 61 kB 61 kB ✓
Overall change 898 kB 898 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more Change
0.pack gzip 2.11 MB 2.11 MB ⚠️ +5.25 kB
index.pack gzip 76.8 kB 76.8 kB N/A
Overall change 2.11 MB 2.11 MB ⚠️ +5.25 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 73fb5f7

@devjiwonchoi devjiwonchoi marked this pull request as draft February 7, 2025 13:59
@devjiwonchoi devjiwonchoi force-pushed the 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more branch from b01be28 to 08f4f3f Compare February 11, 2025 20:11
@devjiwonchoi devjiwonchoi force-pushed the 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more branch from abc1c25 to 73fb5f7 Compare February 11, 2025 20:25
@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 11, 2025 20:27
@devjiwonchoi devjiwonchoi merged commit 9f89c65 into canary Feb 13, 2025
132 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-07-_dev-overlay_style_version_info_staleness_click_text_to_learn_more branch February 13, 2025 18:58
@devjiwonchoi devjiwonchoi mentioned this pull request Feb 13, 2025
Merged
devjiwonchoi added a commit that referenced this pull request Feb 13, 2025
@devjiwonchoi
ci: fix version-staleness test (#76020)
959a312 
The test failed since #75882 was
merged with a lot of test changes, but
#75768 didn't rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

@ztanner ztanner Awaiting requested review from ztanner

@gaojude gaojude Awaiting requested review from gaojude

@raunofreiberg raunofreiberg Awaiting requested review from raunofreiberg

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devjiwonchoi @ijjk @huozhi