Fix incorrect error count #75759

huozhi · 2025-02-06T16:59:55Z

What

fix displayed error count on the toast, which was incorrectly doubled. The reason is dev overlay has a default deduping logic to just check if the error has existed. When react owner stack is enabled, we might create new errors to append owner stack, which leads to create new errors and the error instance comparision won't work.

The fix is to change the dedupe logic to comparing the error.stack, which should be more accurate than comparing erorr instances.

Other Changes

The testing util of asserting toast exsistence is broken since you can't access outer scope variable isNewOverlay in browser.eval(). Fixed it by alignning the DOM attributes.
Add new helper to assert the count of error count on indicator/toast.
Add some guard code in react owner stack error helpers

Closes NDX-777

ijjk · 2025-02-06T17:12:46Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
buildDuration	19.7s	17.1s	N/A
buildDurationCached	16.1s	13.5s	N/A
nodeModulesSize	392 MB	392 MB	⚠️ +4.7 kB
nextStartRea..uration (ms)	443ms	425ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	239 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	519 B	520 B	N/A
Overall change	524 B	524 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
middleware-b..fest.js gzip	675 B	674 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
app-page-exp...dev.js gzip	393 kB	393 kB	N/A
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	N/A
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	896 kB	896 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js fix/hydration-errors-count	Change
0.pack gzip	2.1 MB	2.11 MB	⚠️ +7.13 kB
index.pack gzip	75.1 kB	75.6 kB	⚠️ +560 B
Overall change	2.18 MB	2.18 MB	⚠️ +7.69 kB

Diff details

Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 60ca54c

ijjk · 2025-02-06T17:37:34Z

Tests Passed

huozhi · 2025-02-07T00:28:02Z

packages/next/src/client/components/errors/use-error-handler.ts

@@ -70,8 +70,8 @@ export function useErrorHandler(
      )

      // Reset error queues.
-      errorQueue.splice(0, 0)
-      rejectionQueue.splice(0, 0)
+      errorQueue.splice(0, errorQueue.length)


This is not critical for the test, if you remove the change here tests can also pass. Just change it to make it correctly reset the error queue

huozhi · 2025-02-07T00:29:00Z

test/lib/next-test-utils.ts

-        [].slice.call(document.querySelectorAll('nextjs-portal')).find((p) =>
-          p.shadowRoot.querySelector(
-            // TODO(jiwon): data-nextjs-toast may not be an error indicator in new UI
-            isNewDevOverlay ? '[data-issues]' : '[data-nextjs-toast]'


This won't work, which will always throw as isNewDevOverlay can't be accessed in browser.eval

huozhi added 2 commits February 6, 2025 17:57

locate the issue

b836647

enable test to make it fail

6b2fd69

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 6, 2025

huozhi changed the title ~~Fix wrong error count~~ Fix incorrect error count Feb 6, 2025

huozhi force-pushed the fix/hydration-errors-count branch from 034a4b3 to 6b2fd69 Compare February 6, 2025 17:16

enable runing hydration test with ppr

0a27443

ijjk added the tests label Feb 6, 2025

huozhi added 5 commits February 6, 2025 19:20

fix duplicated

ccae52e

refine test

9d75a90

fix issue count

52abd22

fix duplicate error when owner stack is enabled

eed0cd8

fix error deduping

0a23481

huozhi commented Feb 7, 2025

View reviewed changes

improve flaky test

f43dbc2

huozhi marked this pull request as ready for review February 7, 2025 00:34

huozhi requested review from devjiwonchoi, ztanner, gaojude and eps1lon February 7, 2025 00:34

gaojude approved these changes Feb 7, 2025

View reviewed changes

huozhi added 2 commits February 7, 2025 02:22

fix test util

28cbdec

fix dom attr

60ca54c

huozhi merged commit b9277bf into canary Feb 7, 2025
130 checks passed

huozhi deleted the fix/hydration-errors-count branch February 7, 2025 11:58

github-actions bot added the locked label Feb 21, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect error count #75759

Fix incorrect error count #75759

huozhi commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 6, 2025 •

edited

Loading

huozhi Feb 7, 2025

huozhi Feb 7, 2025

Fix incorrect error count #75759

Fix incorrect error count #75759

Conversation

huozhi commented Feb 6, 2025 • edited Loading

What

Other Changes

ijjk commented Feb 6, 2025 • edited Loading

Stats from current PR

ijjk commented Feb 6, 2025 • edited Loading

Tests Passed

huozhi Feb 7, 2025

Choose a reason for hiding this comment

huozhi Feb 7, 2025

Choose a reason for hiding this comment

huozhi commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 6, 2025 •

edited

Loading

ijjk commented Feb 6, 2025 •

edited

Loading