Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] add and apply merge class names util #75758

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 6, 2025

Add and apply the merge multiple class names util.

Closes NDX-664

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 6, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review February 6, 2025 16:29
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
buildDuration 20.4s 18.2s N/A
buildDurationCached 17.2s 14.4s N/A
nodeModulesSize 392 MB 392 MB ⚠️ +11.3 kB
nextStartRea..uration (ms) 455ms 470ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
5306-HASH.js gzip 54.2 kB 54.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
middleware-b..fest.js gzip 676 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
app-page-exp...dev.js gzip 393 kB 393 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 896 kB 896 kB
build cache
vercel/next.js canary vercel/next.js 02-07-dev-overlay_add_and_apply_clsx Change
0.pack gzip 2.11 MB 2.1 MB N/A
index.pack gzip 75 kB 74.3 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 56cf74a

@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Failing test suites

Commit: 56cf74a

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/development/app-dir/hmr-shared-css/hmr-shared-css.test.ts (PPR)

  • hmr-app-and-pages > should do HMR when app router and pages router have shared CSS
Expand output

● hmr-app-and-pages › should do HMR when app router and pages router have shared CSS

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  252 |   let next: NextInstance | undefined
  253 |   if (!skipped) {
> 254 |     beforeAll(async () => {
      |     ^
  255 |       next = await createNext(options)
  256 |     })
  257 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils/index.ts:254:5)
  at development/app-dir/hmr-shared-css/hmr-shared-css.test.ts:5:33
  at Object.describe (development/app-dir/hmr-shared-css/hmr-shared-css.test.ts:4:1)

Read more about building and testing Next.js in contributing.md.

devjiwonchoi and others added 2 commits February 7, 2025 03:12
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
@devjiwonchoi devjiwonchoi requested a review from huozhi February 6, 2025 18:18
@devjiwonchoi devjiwonchoi changed the title [dev-overlay] add and apply clsx [dev-overlay] add and apply merge class names util Feb 6, 2025
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
@devjiwonchoi devjiwonchoi requested a review from huozhi February 6, 2025 18:34
@devjiwonchoi devjiwonchoi merged commit 791ca66 into canary Feb 6, 2025
123 of 124 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-07-_dev-overlay_add_and_apply_clsx_ branch February 6, 2025 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants