Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] improve race condition handling of scheduling #75748

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 6, 2025

Closes PACK-3960

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 6, 2025
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Tests Passed

@sokra sokra force-pushed the sokra/schedule-race-condition branch from 1d009f1 to 2b41f2d Compare February 11, 2025 08:44
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Feb 11, 2025
@sokra sokra changed the base branch from canary to sokra/fix-active-counting-hanging February 11, 2025 08:45
@sokra sokra changed the title improve race condition handling of scheduling [Turbopack] improve race condition handling of scheduling Feb 11, 2025
@sokra sokra force-pushed the sokra/fix-active-counting-hanging branch 2 times, most recently from 5057314 to 4bc9ed3 Compare February 11, 2025 08:56
@sokra sokra force-pushed the sokra/schedule-race-condition branch from 2b41f2d to 4e5e553 Compare February 11, 2025 08:56
@ijjk
Copy link
Member

ijjk commented Feb 11, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
buildDuration 20.1s 17.1s N/A
buildDurationCached 16.2s 13.5s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 446ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
5306-HASH.js gzip 55 kB 55 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.47 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 246 B 245 B N/A
main-HASH.js gzip 34.7 kB 34.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
_buildManifest.js gzip 748 B 748 B
Overall change 748 B 748 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
middleware-b..fest.js gzip 676 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
app-page-exp...dev.js gzip 394 kB 394 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 382 kB 382 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.7 kB 25.7 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.69 kB 9.69 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.1 kB 61.1 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/schedule-race-condition Change
0.pack gzip 2.11 MB 2.12 MB ⚠️ +422 B
index.pack gzip 75 kB 76.4 kB ⚠️ +1.31 kB
Overall change 2.19 MB 2.19 MB ⚠️ +1.73 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: a9ef883

@sokra sokra changed the base branch from sokra/fix-active-counting-hanging to graphite-base/75748 February 11, 2025 09:24
@sokra sokra force-pushed the sokra/schedule-race-condition branch from 4e5e553 to f5b3fc1 Compare February 11, 2025 09:25
@sokra sokra force-pushed the graphite-base/75748 branch from 4bc9ed3 to 4744bc7 Compare February 11, 2025 09:25
@sokra sokra changed the base branch from graphite-base/75748 to canary February 11, 2025 09:25
@sokra sokra force-pushed the sokra/schedule-race-condition branch from f5b3fc1 to b188d77 Compare February 11, 2025 09:25
@sokra sokra requested a review from mischnic February 11, 2025 10:02
@sokra sokra marked this pull request as ready for review February 11, 2025 10:03
@sokra sokra force-pushed the sokra/schedule-race-condition branch from b188d77 to a9ef883 Compare February 12, 2025 14:57
@timneutkens timneutkens merged commit f95d8b9 into canary Feb 13, 2025
131 checks passed
@timneutkens timneutkens deleted the sokra/schedule-race-condition branch February 13, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants