Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable new overlay properly when env var is set #75747

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 6, 2025

What

When you pass __NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY in cli it should also enable the react owner stack. Currently only setting the experimental flag in next.config.js will enable react owner stack. It's not consistent. This PR fixes the issue

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 6, 2025
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Tests Passed

@huozhi huozhi marked this pull request as ready for review February 6, 2025 13:50
Copy link

vercel bot commented Feb 6, 2025

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding:

packages/next/src/server/config.ts

@huozhi huozhi changed the title fix: enable flag properly when env flag is set fix: enable new overlay properly when env var is set Feb 6, 2025
@huozhi huozhi merged commit f37a454 into canary Feb 6, 2025
130 of 131 checks passed
@huozhi huozhi deleted the fix/errors-exp-flag branch February 6, 2025 14:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants