Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null if Redbox has no component stack #75744

Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 6, 2025

... and stop waiting for it. The util is supposed to be called after assertHasRedbox (hence the "get" prefix). Waiting just makes failing tests slower.

and stop waiting for it. The util is supposed to be
called after `assertHasRedbox` (hence the "get" prefix).
Waiting just makes failing tests slower.
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Feb 6, 2025
Copy link
Member Author

eps1lon commented Feb 6, 2025

@eps1lon eps1lon marked this pull request as ready for review February 6, 2025 21:36
@eps1lon eps1lon requested review from gaojude and huozhi and removed request for gaojude February 6, 2025 21:36
@eps1lon eps1lon merged commit 7fcf142 into canary Feb 7, 2025
131 of 132 checks passed
@eps1lon eps1lon deleted the sebbie/02-06-return_null_if_redbox_has_no_component_stack branch February 7, 2025 00:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants