Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: source locations as u32 #75705

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Turbopack: source locations as u32 #75705

merged 4 commits into from
Feb 11, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Feb 5, 2025

No real signficant perf difference, but seems still worthwhile. Especially since the sourcemap library and swc both return u32 anyway. And you likely don't have files with more than 4.294.967.296 bytes, lines, or column width.

snapshot in with_modules c2c661b1e9 (previous PR in stack)
13,3 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  491.50s user 79.78s system 856% cpu 1:06.69 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  495.62s user 78.61s system 852% cpu 1:07.36 total

locations as u32 b422f84b24
13,25 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  494.85s user 77.34s system 855% cpu 1:06.87 total

Closes PACK-3940

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 5, 2025
Copy link
Contributor Author

mischnic commented Feb 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic marked this pull request as ready for review February 5, 2025 19:10
@mischnic mischnic requested review from bgw, wbinnssmith and sokra February 5, 2025 19:10
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
buildDuration 19.7s 18s N/A
buildDurationCached 17s 14.4s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 456ms 457ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
5306-HASH.js gzip 54.8 kB 54.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
index.html gzip 524 B 524 B
link.html gzip 540 B 537 B N/A
withRouter.html gzip 521 B 520 B N/A
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
middleware-b..fest.js gzip 675 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 61 kB 61 kB
Overall change 1.67 MB 1.67 MB
build cache
vercel/next.js canary vercel/next.js mischnic/sourcepos-u32 Change
0.pack gzip 2.11 MB 2.11 MB N/A
index.pack gzip 76.1 kB 76.1 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: b707573

@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from afbe760 to f837a6c Compare February 6, 2025 14:55
@mischnic mischnic force-pushed the mischnic/available-withmodules-snapshot branch 3 times, most recently from e749ae0 to 50cd139 Compare February 6, 2025 15:43
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from f837a6c to ad3f8a9 Compare February 6, 2025 15:43
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Tests Passed

@mischnic mischnic changed the base branch from mischnic/available-withmodules-snapshot to graphite-base/75705 February 6, 2025 16:19
@mischnic mischnic force-pushed the graphite-base/75705 branch from 50cd139 to 4d21afa Compare February 6, 2025 16:19
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from ad3f8a9 to 1d98dc1 Compare February 6, 2025 16:19
@mischnic mischnic changed the base branch from graphite-base/75705 to canary February 6, 2025 16:20
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch 3 times, most recently from 4089a36 to b2c963a Compare February 11, 2025 10:24
@mischnic mischnic changed the base branch from canary to graphite-base/75705 February 11, 2025 12:59
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from b2c963a to 390262e Compare February 11, 2025 12:59
@mischnic mischnic changed the base branch from graphite-base/75705 to mischnic/get-node-result February 11, 2025 12:59
@mischnic mischnic changed the base branch from mischnic/get-node-result to canary February 11, 2025 13:00
Copy link

graphite-app bot commented Feb 11, 2025

Merge activity

  • Feb 11, 8:00 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 11, 1:46 PM EST: A user merged this pull request with Graphite.

@mischnic mischnic changed the base branch from canary to mischnic/get-node-result February 11, 2025 14:49
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from 390262e to 3e3f4fb Compare February 11, 2025 14:50
@mischnic mischnic force-pushed the mischnic/get-node-result branch from 7dc097b to cdacda9 Compare February 11, 2025 14:50
@mischnic mischnic changed the base branch from mischnic/get-node-result to graphite-base/75705 February 11, 2025 17:42
@mischnic mischnic deleted the branch canary February 11, 2025 17:42
@mischnic mischnic closed this Feb 11, 2025
@mischnic mischnic reopened this Feb 11, 2025
@mischnic mischnic force-pushed the graphite-base/75705 branch from cdacda9 to c616304 Compare February 11, 2025 17:43
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch 2 times, most recently from 8939e17 to fce4f50 Compare February 11, 2025 17:43
@mischnic mischnic changed the base branch from graphite-base/75705 to canary February 11, 2025 17:44
@mischnic mischnic force-pushed the mischnic/sourcepos-u32 branch from fce4f50 to b707573 Compare February 11, 2025 17:44
@mischnic mischnic merged commit 62214f4 into canary Feb 11, 2025
131 checks passed
@mischnic mischnic deleted the mischnic/sourcepos-u32 branch February 11, 2025 18:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants