-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbopack: source locations as u32 #75705
Merged
Merged
+100
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sokra
approved these changes
Feb 5, 2025
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
wbinnssmith
approved these changes
Feb 5, 2025
afbe760
to
f837a6c
Compare
e749ae0
to
50cd139
Compare
f837a6c
to
ad3f8a9
Compare
Tests Passed |
50cd139
to
4d21afa
Compare
ad3f8a9
to
1d98dc1
Compare
4089a36
to
b2c963a
Compare
b2c963a
to
390262e
Compare
390262e
to
3e3f4fb
Compare
7dc097b
to
cdacda9
Compare
cdacda9
to
c616304
Compare
8939e17
to
fce4f50
Compare
fce4f50
to
b707573
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real signficant perf difference, but seems still worthwhile. Especially since the
sourcemap
library andswc
both return u32 anyway. And you likely don't have files with more than 4.294.967.296 bytes, lines, or column width.Closes PACK-3940