Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: less tasks in with_modules #75700

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Feb 5, 2025

Way less turbo tasks

Less CPU time, 300mb less memory.

testing against 0293c96cf32

uncell AstPath 77d7015554 (PR below in this stack)
13,65 GB 
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  505.04s user 83.92s system 853% cpu 1:09.00 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  509.03s user 84.26s system 829% cpu 1:11.53 total

snapshot in with_modules c2c661b1e9
13,3 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  491.50s user 79.78s system 856% cpu 1:06.69 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  495.62s user 78.61s system 852% cpu 1:07.36 total

Closes PACK-3915

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 5, 2025
Copy link
Contributor Author

mischnic commented Feb 5, 2025

@mischnic mischnic changed the title Turbopack: snapshot in with_modules Turbopack: less tasks in with_modules Feb 5, 2025
@mischnic mischnic marked this pull request as ready for review February 5, 2025 17:12
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
buildDuration 18.5s 16.6s N/A
buildDurationCached 15.7s 13.1s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 428ms 438ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
5306-HASH.js gzip 54.2 kB 54.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
middleware-b..fest.js gzip 674 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/available-withmodules-snapshot Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +3.17 kB
index.pack gzip 74.9 kB 74.8 kB N/A
Overall change 2.1 MB 2.11 MB ⚠️ +3.17 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 50cd139

@mischnic mischnic force-pushed the mischnic/available-withmodules-snapshot branch from c2c661b to 452c9fa Compare February 6, 2025 14:55
@mischnic mischnic force-pushed the mischnic/uncell-ast-path branch from 77d7015 to aa6b767 Compare February 6, 2025 14:55
@mischnic mischnic changed the base branch from mischnic/uncell-ast-path to graphite-base/75700 February 6, 2025 15:42
@mischnic mischnic force-pushed the mischnic/available-withmodules-snapshot branch from 452c9fa to e749ae0 Compare February 6, 2025 15:43
@mischnic mischnic force-pushed the graphite-base/75700 branch from aa6b767 to 84e75d1 Compare February 6, 2025 15:43
@mischnic mischnic changed the base branch from graphite-base/75700 to canary February 6, 2025 15:43
@mischnic mischnic force-pushed the mischnic/available-withmodules-snapshot branch from e749ae0 to 50cd139 Compare February 6, 2025 15:43
@ijjk
Copy link
Member

ijjk commented Feb 6, 2025

Tests Passed

@mischnic mischnic merged commit 4d21afa into canary Feb 6, 2025
131 checks passed
Copy link
Contributor Author

mischnic commented Feb 6, 2025

Merge activity

  • Feb 6, 11:19 AM EST: A user merged this pull request with Graphite.

@mischnic mischnic deleted the mischnic/available-withmodules-snapshot branch February 6, 2025 16:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants