Turbopack: uncell AstPath #75695

mischnic · 2025-02-05T15:53:43Z

Remove the last remaining AstPath cells
Also box a rare CodeGen enum variant (brings down enum size from 128 bytes to 48 bytes)
code_gens.shrink_to_fit()

Might help memory slightly, but it's bordering on measurement noise:

testing against 0293c96cf32

canary b6f8743ecd
13,75 GB 
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  507.86s user 77.80s system 847% cpu 1:09.11 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  503.13s user 77.86s system 855% cpu 1:07.90 total


uncell AstPath 3ec676fea5
13,7 GB 
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  505.04s user 83.92s system 853% cpu 1:09.00 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  509.03s user 84.26s system 829% cpu 1:11.53 total

Closes PACK-3913

mischnic · 2025-02-05T15:54:15Z

Turbopack: source locations as u32 #75705
Turbopack: less tasks in with_modules #75700
Turbopack: uncell AstPath #75695 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

mischnic · 2025-02-05T16:06:13Z

turbopack/crates/turbopack-ecmascript/src/references/mod.rs

-#[derive(Hash, Debug, Clone)]
+#[derive(Hash, Debug, Clone, Eq, Serialize, Deserialize, PartialEq, TraceRawVcs)]
 pub struct AstPath(#[turbo_tasks(trace_ignore)] Vec<AstParentKind>);

+impl TaskInput for AstPath {
+    fn is_transient(&self) -> bool {
+        false
+    }
+}
+unsafe impl NonLocalValue for AstPath {}


@bgw @sokra Not entirely sure if this manual TaskInput impl is correct? AstParentKind is a type from swc

Also, should TaskInput really also be an unsafe trait?

ijjk · 2025-02-05T16:17:08Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
buildDuration	22.4s	19.9s	N/A
buildDurationCached	19.2s	16.5s	N/A
nodeModulesSize	392 MB	392 MB	✓
nextStartRea..uration (ms)	489ms	513ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
5306-HASH.js gzip	54 kB	54 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	239 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	538 B	✓
withRouter.html gzip	519 B	520 B	N/A
Overall change	1.06 kB	1.06 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
middleware-b..fest.js gzip	674 B	673 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
app-page-exp...dev.js gzip	393 kB	393 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	380 kB	380 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.8 kB	40.8 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	1.67 MB	1.67 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js mischnic/uncell-ast-path	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +1.04 kB
index.pack gzip	76.7 kB	74.6 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +1.04 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 77d7015

ijjk · 2025-02-05T16:34:47Z

Tests Passed

mischnic · 2025-02-06T15:42:46Z

Merge activity

Feb 6, 10:42 AM EST: A user merged this pull request with Graphite.

ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 5, 2025

mischnic changed the title ~~Box AMD codegen~~ Turbopack: uncell AstPath Feb 5, 2025

mischnic marked this pull request as ready for review February 5, 2025 15:57

mischnic force-pushed the mischnic/uncell-ast-path branch from 5852773 to 77d7015 Compare February 5, 2025 16:05

mischnic commented Feb 5, 2025

View reviewed changes

This was referenced Feb 5, 2025

Turbopack: less tasks in with_modules #75700

Merged

Turbopack: source locations as u32 #75705

Merged

mischnic requested a review from sokra February 5, 2025 19:11

sokra approved these changes Feb 5, 2025

View reviewed changes

mischnic added 3 commits February 6, 2025 15:50

Box AMD codegen

e4028ba

code_gens.shrink_to_fit

a465c54

Uncell AstPath

aa6b767

mischnic force-pushed the mischnic/uncell-ast-path branch from 77d7015 to aa6b767 Compare February 6, 2025 14:55

mischnic merged commit 84e75d1 into canary Feb 6, 2025
130 of 131 checks passed

mischnic deleted the mischnic/uncell-ast-path branch February 6, 2025 15:42

github-actions bot added the locked label Feb 21, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turbopack: uncell AstPath #75695

Turbopack: uncell AstPath #75695

mischnic commented Feb 5, 2025 •

edited by padmaia

Loading

mischnic commented Feb 5, 2025 •

edited

Loading

mischnic Feb 5, 2025 •

edited

Loading

ijjk commented Feb 5, 2025

ijjk commented Feb 5, 2025 •

edited

Loading

mischnic commented Feb 6, 2025

Turbopack: uncell AstPath #75695

Turbopack: uncell AstPath #75695

Conversation

mischnic commented Feb 5, 2025 • edited by padmaia Loading

mischnic commented Feb 5, 2025 • edited Loading

mischnic Feb 5, 2025 • edited Loading

Choose a reason for hiding this comment

ijjk commented Feb 5, 2025

Stats from current PR

ijjk commented Feb 5, 2025 • edited Loading

Tests Passed

mischnic commented Feb 6, 2025

Merge activity

mischnic commented Feb 5, 2025 •

edited by padmaia

Loading

mischnic commented Feb 5, 2025 •

edited

Loading

mischnic Feb 5, 2025 •

edited

Loading

ijjk commented Feb 5, 2025 •

edited

Loading