From 720346caf7fa2065a9039ce57eb6044cd428d18b Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Wed, 5 Feb 2025 14:32:29 +0100 Subject: [PATCH 1/2] test: fix eslint plugin test --- .../eslint-plugin-deps/index.test.ts | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/test/production/eslint-plugin-deps/index.test.ts b/test/production/eslint-plugin-deps/index.test.ts index 029e46a7781de..cb1d839da3ad0 100644 --- a/test/production/eslint-plugin-deps/index.test.ts +++ b/test/production/eslint-plugin-deps/index.test.ts @@ -82,6 +82,44 @@ describe('eslint plugin deps', () => { { "allowComparingNullableBooleansToTrue": false } ] } +} + `, + 'tsconfig.json': `{ + "compilerOptions": { + "target": "ES2017", + "lib": [ + "dom", + "dom.iterable", + "esnext" + ], + "allowJs": true, + "skipLibCheck": true, + "strict": false, + "strictNullChecks": true, + "noEmit": true, + ${/* The rule @typescript-eslint/no-unnecessary-boolean-literal-compare requires the `strictNullChecks` compiler option to be turned on to function correctly. */ ''} + "incremental": true, + "module": "esnext", + "esModuleInterop": true, + "moduleResolution": "node", + "resolveJsonModule": true, + "isolatedModules": true, + "jsx": "preserve", + "plugins": [ + { + "name": "next" + } + ] + }, + "include": [ + "next-env.d.ts", + ".next/types/**/*.ts", + "**/*.ts", + "**/*.tsx" + ], + "exclude": [ + "node_modules", + ] } `, }, From 61c89a585974417616d79a5c94a48a1773f0315b Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Wed, 5 Feb 2025 14:48:23 +0100 Subject: [PATCH 2/2] use normal comment --- test/production/eslint-plugin-deps/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/production/eslint-plugin-deps/index.test.ts b/test/production/eslint-plugin-deps/index.test.ts index cb1d839da3ad0..5a3088cb07f8f 100644 --- a/test/production/eslint-plugin-deps/index.test.ts +++ b/test/production/eslint-plugin-deps/index.test.ts @@ -95,9 +95,9 @@ describe('eslint plugin deps', () => { "allowJs": true, "skipLibCheck": true, "strict": false, + // The rule @typescript-eslint/no-unnecessary-boolean-literal-compare requires the \`strictNullChecks\` compiler option to be turned on to function correctly. "strictNullChecks": true, "noEmit": true, - ${/* The rule @typescript-eslint/no-unnecessary-boolean-literal-compare requires the `strictNullChecks` compiler option to be turned on to function correctly. */ ''} "incremental": true, "module": "esnext", "esModuleInterop": true,