Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(turbo-tasks): Remove support for local_cells (a specific mode of local tasks we ended up not using) #75672

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Feb 5, 2025

Local cells would allow us to avoid allocating real cells for data passed to local task functions.

Unfortunately, in practice, we manually resolve most arguments passed to local task functions, which would defeat this optimization.

I was holding onto this in the hopes that we might end up using it, but that seems fleeting:

  • We could get similar benefits by scanning for unreferenced cells at the end of function execution using TraceRawVcs at the cost of a bit of execution time. This would work even on Vcs that were resolved.
  • For ergonomics reasons, we want to eventually rename ResolvedVc to Vc (and Vc to something like UnresolvedVc), which will probably lead to us resolving even more stuff, breaking this potential optimization even more.
  • Cache eviction may do a good enough job of removing cells, the bigger enemy are the harder-to-evict tasks, which our current version of local tasks does do a good job of reducing.

Meanwhile, it makes the code harder to follow, and could cause issues if this codepath somehow got activated.

Closes PACK-3903

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 5, 2025
Copy link
Member Author

bgw commented Feb 5, 2025

@bgw bgw requested review from mischnic and sokra February 5, 2025 05:45
@bgw bgw marked this pull request as ready for review February 5, 2025 05:48
@bgw bgw force-pushed the bgw/rm-local-cells branch from 715e332 to 93b5f53 Compare February 5, 2025 05:51
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
buildDuration 20.5s 15.5s N/A
buildDurationCached 14.6s 12.2s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 417ms 415ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
index.html gzip 525 B 524 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
middleware-b..fest.js gzip 676 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 380 kB 380 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/rm-local-cells Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +208 B
index.pack gzip 75.1 kB 74.8 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +208 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 93b5f53

@bgw bgw merged commit a29bfa2 into canary Feb 5, 2025
131 checks passed
@bgw bgw deleted the bgw/rm-local-cells branch February 5, 2025 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants