Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] sort spans by start date in tracing #75642

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 4, 2025

What?

Due to the thread local buffer of spans it happens that they are in unexpected order in the trace file. This sorts them by start date.

Closes PACK-3888

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Feb 4, 2025
Copy link
Member Author

sokra commented Feb 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra force-pushed the sokra/trace-order branch from 33c2d18 to 7d081d6 Compare February 4, 2025 08:20
@sokra sokra changed the title sort spans by start date in tracing [Turbopack] sort spans by start date in tracing Feb 4, 2025
@sokra sokra requested a review from timneutkens February 4, 2025 08:24
@sokra sokra marked this pull request as ready for review February 4, 2025 08:26
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/trace-order Change
buildDuration 16.4s 14.7s N/A
buildDurationCached 13.8s 11.6s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 389ms 392ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/trace-order Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/trace-order Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/trace-order Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 325 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/trace-order Change
_buildManifest.js gzip 748 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/trace-order Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/trace-order Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/trace-order Change
middleware-b..fest.js gzip 669 B 664 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/trace-order Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/trace-order Change
0.pack gzip 2.11 MB 2.1 MB N/A
index.pack gzip 75.6 kB 77 kB ⚠️ +1.39 kB
Overall change 75.6 kB 77 kB ⚠️ +1.39 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: d001cf3

@sokra sokra force-pushed the sokra/trace-order branch from 7d081d6 to d001cf3 Compare February 4, 2025 17:58
@sokra sokra requested a review from mischnic February 4, 2025 17:59
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025

Tests Passed

@sokra sokra merged commit cffa257 into canary Feb 5, 2025
131 checks passed
Copy link
Member Author

sokra commented Feb 5, 2025

Merge activity

  • Feb 4, 7:13 PM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/trace-order branch February 5, 2025 00:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants