Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incoming requests should use plural #75582

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 3, 2025

What

Fixes the mismatch between docs and the feature code, aligning with docs and other properties in logging option.

@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Failing test suites

Commit: eda5790

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

  • persistent-caching > should persistent cache loaders
Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1738602280526"
Received: "Timestamp = 1738602300357"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi marked this pull request as ready for review February 3, 2025 14:04
@huozhi huozhi requested a review from ztanner February 3, 2025 14:04
@huozhi huozhi merged commit 7c3705d into canary Feb 3, 2025
126 of 129 checks passed
@huozhi huozhi deleted the fix/incoming-request branch February 3, 2025 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants