add additional x-middleware-set-cookie filtering #75561
Merged
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztanner
changed the title
ijjk
approved these changes
Feb 1, 2025
Tests Passed |
ztanner
force-pushed
the
02-01-filter_x-middleware-set-cookie_in_route_handlers
branch
from
77081d0 to
c654bff
Compare
ztanner
deleted the
02-01-filter_x-middleware-set-cookie_in_route_handlers
branch
|
Really appreciate this is implemented. Thank you!! |
|
This was a pain to debug that broke our app :) would be great if this can land before 2.0 canary lands. Thank you. |
ztanner
added a commit
that referenced
this pull request
Feb 10, 2025
Previously when we removed this from the response we only did so for requests that flowed through middleware and static handlers. We should ensure it's filtered in `sendResponse` as well. The header is only needed internally.
ztanner
added a commit
that referenced
this pull request
Feb 10, 2025
Previously when we removed this from the response we only did so for requests that flowed through middleware and static handlers. We should ensure it's filtered in `sendResponse` as well. The header is only needed internally.
This was referenced Feb 10, 2025
ztanner
added a commit
that referenced
this pull request
Feb 10, 2025
ztanner
added a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we removed this from the response we only did so for requests that flowed through middleware and static handlers. We should ensure it's filtered in
sendResponseas well. The header is only needed internally.