Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack: make IssueSource a TaskInput #75542

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Turbopack: make IssueSource a TaskInput #75542

merged 2 commits into from
Feb 5, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 31, 2025 •
edited by padmaia
Loading

Meaning fewer cells and fewer tasks

No measureable perf difference

Closes PACK-3896

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 31, 2025
@mischnic mischnic changed the title Make IssueSource a TaskInput Turbopack: make IssueSource a TaskInput Jan 31, 2025
@mischnic Graphite App
Copy link
Contributor Author

mischnic commented Jan 31, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic mentioned this pull request Jan 31, 2025
Merged
@mischnic mischnic marked this pull request as ready for review January 31, 2025 21:51
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from bd58ad6 to 6bb0e1d Compare February 3, 2025 09:58
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 24cfcce to 33124a5 Compare February 3, 2025 09:58
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 6bb0e1d to 10db78b Compare February 3, 2025 11:56
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 33124a5 to 4c0c696 Compare February 3, 2025 11:56
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 10db78b to 171c2b8 Compare February 3, 2025 14:53
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 4c0c696 to 44f553c Compare February 3, 2025 14:53
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 171c2b8 to 0dfb48b Compare February 4, 2025 08:46
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch 2 times, most recently from 9200e70 to 5733e95 Compare February 4, 2025 08:53
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
buildDuration 17.5s 14.7s N/A
buildDurationCached 14s 11.6s N/A
nodeModulesSize 392 MB 392 MB ✓
nextStartRea..uration (ms) 390ms 410ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
middleware-b..fest.js gzip 675 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
app-page-exp...dev.js gzip 385 kB 385 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 372 kB 372 kB ✓
app-page.run..prod.js gzip 128 kB 128 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.8 kB 40.8 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.1 kB 60.1 kB ✓
Overall change 1.65 MB 1.65 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/uncell-issuesource Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +881 B
index.pack gzip 75.1 kB 75.2 kB N/A
Overall change 2.1 MB 2.11 MB ⚠️ +881 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 3a0ac20

@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 1703383 to d849032 Compare February 4, 2025 10:39
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 5733e95 to 8ada131 Compare February 4, 2025 10:39
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from d849032 to b3370a5 Compare February 4, 2025 15:43
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch 2 times, most recently from d720896 to 2200847 Compare February 4, 2025 16:18
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from b3370a5 to a95184b Compare February 4, 2025 16:18
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 2200847 to e18866e Compare February 4, 2025 17:36
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from a95184b to 734c18d Compare February 4, 2025 17:36
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from e18866e to f6afaba Compare February 4, 2025 18:50
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 734c18d to 61285ec Compare February 4, 2025 18:50
@mischnic mischnic changed the base branch from mischnic/codegen-enum to graphite-base/75542 February 4, 2025 20:00
@mischnic mischnic force-pushed the graphite-base/75542 branch from 61285ec to 477eaf0 Compare February 4, 2025 20:01
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from f6afaba to 90c3265 Compare February 4, 2025 20:01
@mischnic mischnic changed the base branch from graphite-base/75542 to canary February 4, 2025 20:01
@mischnic mischnic force-pushed the mischnic/uncell-issuesource branch from 90c3265 to 3a0ac20 Compare February 4, 2025 20:01
@timneutkens timneutkens merged commit a50782c into canary Feb 5, 2025
131 checks passed
@timneutkens timneutkens deleted the mischnic/uncell-issuesource branch February 5, 2025 10:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mischnic @ijjk @sokra @timneutkens