Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: remove last stray lint ignore comments #75519

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 31, 2025

The lint rule was removed long ago

Closes PACK-3901

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 31, 2025
@mischnic mischnic requested a review from timneutkens January 31, 2025 16:43
@mischnic mischnic enabled auto-merge (squash) February 3, 2025 13:21
@mischnic mischnic force-pushed the mischinc/remove-lint-comments branch from 8262f97 to 807977e Compare February 5, 2025 12:52
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Failing test suites

Commit: 807977e

pnpm test-dev-turbo test/development/acceptance/error-recovery.test.ts (turbopack)

  • ReactRefreshLogBox turbo > logbox: can recover from a syntax error without losing state
Expand output

● ReactRefreshLogBox turbo › logbox: can recover from a syntax error without losing state

TIMED OUT: /Count: 1/



undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (development/acceptance/error-recovery.test.ts:66:5)

Read more about building and testing Next.js in contributing.md.

@mischnic mischnic merged commit 0f6fc0a into canary Feb 5, 2025
129 of 130 checks passed
@mischnic mischnic deleted the mischinc/remove-lint-comments branch February 5, 2025 13:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants