Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack: don't cell CodeGen-s #75513

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Turbopack: don't cell CodeGen-s #75513

merged 12 commits into from
Feb 4, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 31, 2025 •
edited by padmaia
Loading

No need to cell them, they are module-specific anyway.

testing against 0293c96cf32

canary dd676ccbdd:
14,7 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  533.84s user 84.44s system 834% cpu 1:14.10 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  526.68s user 86.15s system 834% cpu 1:13.48 total

plus fewer cells b5ce9afeb5:
14,3 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  517.74s user 85.77s system 831% cpu 1:12.54 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  516.06s user 85.35s system 836% cpu 1:11.89 total

plus no self reads b3370a59ca:
13,8 GB
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  516.65s user 84.11s system 834% cpu 1:12.01 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  518.01s user 87.55s system 839% cpu 1:12.15 total
Old 
canary 82026906a6:
15,3gb
492.59s user 103.43s system 736% cpu 1:20.90 total
495.16s user 96.50s system 739% cpu 1:20.01 total

code-gen bd58ad63a7:
14,95gb
489.30s user 102.66s system 745% cpu 1:19.36 total
501.91s user 105.99s system 743% cpu 1:21.80 total

Closes PACK-3883

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 31, 2025
@mischnic Graphite App
Copy link
Contributor Author

mischnic commented Jan 31, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic changed the title wip Turbopack: don't cell CodeGen-s Jan 31, 2025
@mischnic mischnic marked this pull request as ready for review January 31, 2025 15:09
@mischnic mischnic requested a review from sokra January 31, 2025 15:09
@mischnic mischnic mentioned this pull request Jan 31, 2025
Merged
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from bd58ad6 to 6bb0e1d Compare February 3, 2025 09:58
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/codegen-enum branch 3 times, most recently from 171c2b8 to 0dfb48b Compare February 4, 2025 08:46
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
buildDuration 17.4s 15.6s N/A
buildDurationCached 14.7s 12.5s N/A
nodeModulesSize 392 MB 392 MB ✓
nextStartRea..uration (ms) 416ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
middleware-b..fest.js gzip 676 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
app-page-exp...dev.js gzip 385 kB 385 kB ✓
app-page-exp..prod.js gzip 132 kB 132 kB ✓
app-page-tur..prod.js gzip 145 kB 145 kB ✓
app-page-tur..prod.js gzip 141 kB 141 kB ✓
app-page.run...dev.js gzip 372 kB 372 kB ✓
app-page.run..prod.js gzip 128 kB 128 kB ✓
app-route-ex...dev.js gzip 39.3 kB 39.3 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 40.8 kB 40.8 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
dist_client_...dev.js gzip 356 B 356 B ✓
dist_client_...dev.js gzip 349 B 349 B ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 31.5 kB 31.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 60.1 kB 60.1 kB ✓
Overall change 1.65 MB 1.65 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/codegen-enum Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +3.01 kB
index.pack gzip 74.8 kB 75.5 kB ⚠️ +762 B
Overall change 2.18 MB 2.18 MB ⚠️ +3.77 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 61285ec

@mischnic mischnic force-pushed the mischnic/codegen-enum branch 4 times, most recently from a95184b to 734c18d Compare February 4, 2025 17:36
@mischnic mischnic force-pushed the mischnic/codegen-enum branch from 734c18d to 61285ec Compare February 4, 2025 18:50
@mischnic mischnic merged commit 477eaf0 into canary Feb 4, 2025
132 checks passed
@mischnic mischnic deleted the mischnic/codegen-enum branch February 4, 2025 20:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @ijjk @sokra