Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] use Timestamp type, allow spans less than 1µs #75479

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 30, 2025

What?

The minimum span size of 1µs was a bit limiting. This changes it to 0.01µs.

A trace viewer update is also needed: https://github.com/vercel/turbo-trace-viewer/pull/11

Closes PACK-3880

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 30, 2025
Copy link
Member Author

sokra commented Jan 30, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra changed the title use Timestamp type, allow spans less than 1µs [Turbopack] use Timestamp type, allow spans less than 1µs Jan 30, 2025
@sokra sokra requested a review from timneutkens January 30, 2025 11:50
@sokra sokra marked this pull request as ready for review January 30, 2025 11:50
@sokra sokra force-pushed the sokra/trace-server-accuracy branch from f9552f4 to 123f672 Compare February 3, 2025 07:06
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Tests Passed

@sokra sokra force-pushed the sokra/trace-server-accuracy branch from 123f672 to ca0dd0a Compare February 3, 2025 16:02
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
buildDuration 17.3s 14.5s N/A
buildDurationCached 13.6s 11.2s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 405ms 408ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
middleware-b..fest.js gzip 669 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/trace-server-accuracy Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +2.73 kB
index.pack gzip 74.5 kB 75.4 kB ⚠️ +890 B
Overall change 2.18 MB 2.18 MB ⚠️ +3.62 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 8153a1a

Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

  • Feb 4, 1:46 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Feb 4, 1:08 PM EST: A user merged this pull request with Graphite.

@sokra sokra force-pushed the sokra/trace-server-accuracy branch from ca0dd0a to b00b01b Compare February 4, 2025 08:33
@mischnic mischnic force-pushed the sokra/trace-server-accuracy branch from b00b01b to 8153a1a Compare February 4, 2025 15:45
@sokra sokra merged commit 12b596a into canary Feb 4, 2025
131 checks passed
@sokra sokra deleted the sokra/trace-server-accuracy branch February 4, 2025 18:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants