-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbopack: lazily evaluate obj
for member replacements
#75453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
obj
obj
obj
for member replacements
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
461ed5a
to
377025b
Compare
ea2add2
to
1f181e9
Compare
377025b
to
085e179
Compare
sokra
reviewed
Jan 30, 2025
sokra
reviewed
Jan 30, 2025
sokra
reviewed
Jan 30, 2025
sokra
approved these changes
Jan 30, 2025
1f181e9
to
043ab41
Compare
085e179
to
66d7e1f
Compare
1df9f93
to
ea7529e
Compare
66d7e1f
to
d47098b
Compare
ea7529e
to
5db2e4c
Compare
d47098b
to
c9afd64
Compare
5db2e4c
to
3084d2a
Compare
c9afd64
to
e85a999
Compare
3084d2a
to
e07e5a9
Compare
e85a999
to
c4731a2
Compare
e07e5a9
to
cd9b24c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't even evaluate the left side of
obj.prop
if we know that we don't have anything in the replacement maps that matches*.prop
anyway.This particular helps in huge files with complex code and also containing many member expressions
Closes PACK-3904