Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: lazily evaluate obj for member replacements #75453

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 29, 2025

Don't even evaluate the left side of obj.prop if we know that we don't have anything in the replacement maps that matches *.prop anyway.

This particular helps in huge files with complex code and also containing many member expressions

testing against 0293c96cf32

canary b6f8743ecd
13,75 GB 
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  507.86s user 77.80s system 847% cpu 1:09.11 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  503.13s user 77.86s system 855% cpu 1:07.90 total


mischnic/analyzer-faster-members ed38e94ba2
13,75 GB 
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  499.54s user 79.28s system 857% cpu 1:07.51 total
TURBO_ENGINE_READ_ONLY=1 NEXT_TURBOPACK_TRACING= TURBOPACK=1 TURBOPACK_BUILD=  498.31s user 76.99s system 855% cpu 1:07.27 total

Closes PACK-3904

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 29, 2025
Copy link
Contributor Author

mischnic commented Jan 29, 2025

@mischnic mischnic changed the title Revert "remove tracing" Turbopack: lazily evaluate obj Jan 29, 2025
@mischnic mischnic changed the title Turbopack: lazily evaluate obj Turbopack: lazily evaluate obj Jan 29, 2025
@mischnic mischnic changed the title Turbopack: lazily evaluate obj Turbopack: lazily evaluate obj for member replacements Jan 29, 2025
@ijjk
Copy link
Member

ijjk commented Jan 29, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 29, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
buildDuration 23.3s 20.5s N/A
buildDurationCached 19.4s 16.6s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 492ms 487ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
index.html gzip 523 B 523 B
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 520 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
middleware-b..fest.js gzip 674 B 672 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
app-page-exp...dev.js gzip 393 kB 393 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 380 kB 380 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.67 MB 1.67 MB
build cache
vercel/next.js canary vercel/next.js mischnic/analyzer-faster-members Change
0.pack gzip 2.11 MB 2.1 MB N/A
index.pack gzip 75.3 kB 75.1 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: cd9b24c

@mischnic mischnic force-pushed the mischnic/analyzer-link-cache branch from 461ed5a to 377025b Compare January 30, 2025 09:43
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch 2 times, most recently from ea2add2 to 1f181e9 Compare January 30, 2025 12:04
@mischnic mischnic force-pushed the mischnic/analyzer-link-cache branch from 377025b to 085e179 Compare January 30, 2025 12:04
@mischnic mischnic changed the base branch from mischnic/analyzer-link-cache to graphite-base/75453 January 30, 2025 13:55
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from 1f181e9 to 043ab41 Compare January 30, 2025 14:04
@mischnic mischnic force-pushed the graphite-base/75453 branch from 085e179 to 66d7e1f Compare January 30, 2025 14:04
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from 1df9f93 to ea7529e Compare February 3, 2025 15:00
@mischnic mischnic force-pushed the graphite-base/75453 branch from 66d7e1f to d47098b Compare February 3, 2025 15:00
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from ea7529e to 5db2e4c Compare February 4, 2025 19:58
@mischnic mischnic force-pushed the graphite-base/75453 branch from d47098b to c9afd64 Compare February 4, 2025 19:58
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from 5db2e4c to 3084d2a Compare February 5, 2025 11:21
@mischnic mischnic force-pushed the graphite-base/75453 branch from c9afd64 to e85a999 Compare February 5, 2025 11:21
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from 3084d2a to e07e5a9 Compare February 5, 2025 13:39
@mischnic mischnic force-pushed the graphite-base/75453 branch from e85a999 to c4731a2 Compare February 5, 2025 13:39
@mischnic mischnic changed the base branch from graphite-base/75453 to canary February 5, 2025 13:40
@mischnic mischnic marked this pull request as ready for review February 5, 2025 14:51
@mischnic mischnic force-pushed the mischnic/analyzer-faster-members branch from e07e5a9 to cd9b24c Compare February 5, 2025 14:51
@mischnic mischnic merged commit 94aea60 into canary Feb 5, 2025
132 checks passed
@mischnic mischnic deleted the mischnic/analyzer-faster-members branch February 5, 2025 17:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants