[dev-overlay] fix: do not open error overlay when click indicator #75404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
devjiwonchoi
requested review from
gaojude,
ztanner,
raunofreiberg and
huozhi
and removed request for
gaojude and
ztanner
devjiwonchoi
changed the base branch from
01-28-_devoverlay_display_correct_number_of_errors_on_indicator
to
graphite-base/75404
devjiwonchoi
force-pushed
the
01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator
branch
from
9146f48 to
1683dd7
Compare
devjiwonchoi
force-pushed
the
graphite-base/75404
branch
from
d3fdca9 to
0383d0b
Compare
devjiwonchoi
force-pushed
the
01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator
branch
from
1683dd7 to
810be17
Compare
huozhi
reviewed
Jan 28, 2025
...-overlay/_experimental/internal/components/errors/dev-tools-indicator/internal/next-logo.tsx
Outdated
Show resolved
Hide resolved
devjiwonchoi
changed the title
huozhi
approved these changes
Jan 28, 2025
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| buildDuration | 18.7s | 16.7s | N/A |
| buildDurationCached | 15.6s | 12.8s | N/A |
| nodeModulesSize | 392 MB | 392 MB | |
| nextStartRea..uration (ms) | 444ms | 447ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| 5306-HASH.js gzip | 54 kB | 53.9 kB | N/A |
| 8276.HASH.js gzip | 169 B | 168 B | N/A |
| 8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
| bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | ✓ |
| framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
| main-app-HASH.js gzip | 240 B | 242 B | N/A |
| main-HASH.js gzip | 34.5 kB | 34.4 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
| Overall change | 52.9 kB | 52.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 193 B | 193 B | ✓ |
| amp-HASH.js gzip | 512 B | 510 B | N/A |
| css-HASH.js gzip | 343 B | 342 B | N/A |
| dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
| edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
| head-HASH.js gzip | 363 B | 362 B | N/A |
| hooks-HASH.js gzip | 393 B | 392 B | N/A |
| image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
| index-HASH.js gzip | 268 B | 268 B | ✓ |
| link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
| routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
| script-HASH.js gzip | 397 B | 397 B | ✓ |
| withRouter-HASH.js gzip | 323 B | 326 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 748 B | 747 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| index.html gzip | 523 B | 523 B | ✓ |
| link.html gzip | 537 B | 538 B | N/A |
| withRouter.html gzip | 518 B | 519 B | N/A |
| Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 129 kB | 129 kB | N/A |
| page.js gzip | 210 kB | 210 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 670 B | 664 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
| edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
| Overall change | 844 B | 844 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 386 kB | 386 kB | N/A |
| app-page-exp..prod.js gzip | 131 kB | 131 kB | ✓ |
| app-page-tur..prod.js gzip | 144 kB | 144 kB | ✓ |
| app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
| app-page.run...dev.js gzip | 373 kB | 373 kB | N/A |
| app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
| app-route-ex...dev.js gzip | 39.4 kB | 39.4 kB | ✓ |
| app-route-ex..prod.js gzip | 25 kB | 25 kB | ✓ |
| app-route-tu..prod.js gzip | 25 kB | 25 kB | ✓ |
| app-route-tu..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
| app-route.ru...dev.js gzip | 41 kB | 41 kB | ✓ |
| app-route.ru..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
| dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
| dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
| pages-api-tu..prod.js gzip | 8.81 kB | 8.81 kB | ✓ |
| pages-api.ru...dev.js gzip | 11.5 kB | 11.5 kB | ✓ |
| pages-api.ru..prod.js gzip | 8.8 kB | 8.8 kB | ✓ |
| pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
| pages.runtim...dev.js gzip | 31.3 kB | 31.3 kB | N/A |
| pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
| server.runti..prod.js gzip | 73.7 kB | 73.7 kB | ✓ |
| Overall change | 870 kB | 870 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js 01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator | Change | |
|---|---|---|---|
| 0.pack gzip | 2.1 MB | 2.1 MB | |
| index.pack gzip | 74.8 kB | 75.1 kB | |
| Overall change | 2.17 MB | 2.18 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diffDiff for app-page.runtime.dev.js
failed to diffDiff for pages.runtime.dev.js
Diff too large to display
Merge activity
|
devjiwonchoi
deleted the
01-29-_next_dev-overlay_fix_do_not_open_error_overlay_when_click_indicator
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As we added back the "open/dismiss issues" label next to the indicator at #74975, no need to open error overlay when clicked the indicator.
Before
CleanShot.2025-01-29.at.03.55.07.mp4
After
CleanShot.2025-01-29.at.03.54.28.mp4
Closes https://linear.app/vercel/issue/NDX-721/fix-toggle-behavior-for-collapsed-pill-and-issue-button