-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI polish: dev overlay feedback button #75400
Conversation
Failing test suitesCommit: 77904fb
Expand output● i18n Support basePath › production mode › should handle basePath like pathname
● i18n Support basePath › production mode › should 404 for locale prefixed static assets correctly
● i18n Support basePath › production mode › should serve public file on locale domain
● i18n Support basePath › production mode › should 404 for locale prefixed public folder files
● i18n Support basePath › production mode › should redirect external domain correctly
● i18n Support basePath › production mode › should have domainLocales available on useRouter
● i18n Support basePath › production mode › should not error with similar named cookie to locale cookie
● i18n Support basePath › production mode › should not add duplicate locale key when navigating back to root path with query params
● i18n Support basePath › production mode › should not add duplicate locale key when navigating back to root path with hash
● i18n Support basePath › production mode › should handle navigating back to different casing of locale
● i18n Support basePath › production mode › should have correct initial query values for fallback
● i18n Support basePath › production mode › should navigate to page with same name as development buildId
● i18n Support basePath › production mode › should redirect to locale domain correctly client-side
● i18n Support basePath › production mode › should render the correct href for locale domain
● i18n Support basePath › production mode › should prerender with the correct href for locale domain
● i18n Support basePath › production mode › should render the correct href with locale domains but not on a locale domain
● i18n Support basePath › production mode › should navigate through history with query correctly
● i18n Support basePath › production mode › should not contain backslashes in pages-manifest
● i18n Support basePath › production mode › should resolve href correctly when dynamic route matches locale prefixed
● i18n Support basePath › production mode › should use default locale when no locale is in href with locale false
● i18n Support basePath › production mode › should preload all locales data correctly
● i18n Support basePath › production mode › should have correct values for non-prefixed path
● i18n Support basePath › production mode › should not have hydration mis-match from hash
● i18n Support basePath › production mode › should add i18n config to routes-manifest
● i18n Support basePath › production mode › should output correct prerender-manifest
● i18n Support basePath › production mode › should resolve auto-export dynamic route correctly
● i18n Support basePath › production mode › should navigate to auto-export dynamic page
● i18n Support basePath › production mode › should apply trailingSlash redirect correctly
● i18n Support basePath › production mode › should apply redirects correctly
● i18n Support basePath › production mode › should apply headers correctly
● i18n Support basePath › production mode › should visit API route directly correctly
● i18n Support basePath › production mode › should visit dynamic API route directly correctly
● i18n Support basePath › production mode › should rewrite to API route correctly for en-US locale
● i18n Support basePath › production mode › should rewrite to API route correctly for nl-NL locale
● i18n Support basePath › production mode › should rewrite to API route correctly for nl-BE locale
● i18n Support basePath › production mode › should rewrite to API route correctly for nl locale
● i18n Support basePath › production mode › should rewrite to API route correctly for fr-BE locale
● i18n Support basePath › production mode › should rewrite to API route correctly for fr locale
● i18n Support basePath › production mode › should rewrite to API route correctly for en locale
● i18n Support basePath › production mode › should rewrite to API route correctly for go locale
● i18n Support basePath › production mode › should rewrite to API route correctly for go-BE locale
● i18n Support basePath › production mode › should rewrite to API route correctly for do locale
● i18n Support basePath › production mode › should rewrite to API route correctly for do-BE locale
● i18n Support basePath › production mode › should apply rewrites correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly
● i18n Support basePath › production mode › should navigate with locale prop correctly GSP
● i18n Support basePath › production mode › should navigate with locale false correctly
● i18n Support basePath › production mode › should navigate with locale false correctly GSP
● i18n Support basePath › production mode › should update asPath on the client correctly
● i18n Support basePath › production mode › should handle fallback correctly after generating
● i18n Support basePath › production mode › should use correct default locale for locale domains
● i18n Support basePath › production mode › should not strip locale prefix for default locale with locale domains
● i18n Support basePath › production mode › should not redirect to accept-lang preferred locale with locale cookie
● i18n Support basePath › production mode › should redirect to correct locale domain
● i18n Support basePath › production mode › should handle locales with domain › for domain example.do › should handle locale do-BE
● i18n Support basePath › production mode › should handle locales with domain › for domain example.do › should handle locale go-BE
● i18n Support basePath › production mode › should handle locales with domain › for domain example.com › should handle locale do-BE
● i18n Support basePath › production mode › should handle locales with domain › for domain example.com › should handle locale go-BE
● i18n Support basePath › production mode › should provide defaultLocale correctly for locale domain
● i18n Support basePath › production mode › should generate AMP pages with all locales
● i18n Support basePath › production mode › should work with AMP first page with all locales
● i18n Support basePath › production mode › should generate fallbacks with all locales
● i18n Support basePath › production mode › should generate auto-export page with all locales
● i18n Support basePath › production mode › should generate non-dynamic GSP page with all locales
● i18n Support basePath › production mode › should not output GSP pages that returned notFound
● i18n Support basePath › production mode › should 404 for GSP pages that returned notFound
● i18n Support basePath › production mode › should transition on client properly for page that starts with locale
● i18n Support basePath › production mode › should 404 for GSP that returned notFound on client-transition
● i18n Support basePath › production mode › should render 404 for fallback page that returned 404 on client transition
● i18n Support basePath › production mode › should render 404 for fallback page that returned 404
● i18n Support basePath › production mode › should render 404 for blocking fallback page that returned 404 on client transition
● i18n Support basePath › production mode › should render 404 for blocking fallback page that returned 404
● i18n Support basePath › production mode › should not remove locale prefix for default locale
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly (default locale no prefix
● i18n Support basePath › production mode › should redirect to locale prefixed route for /
● i18n Support basePath › production mode › should use default locale for / without accept-language
● i18n Support basePath › production mode › should load getStaticProps page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback prerender page correctly SSR
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page correctly
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR (default locale no prefix)
● i18n Support basePath › production mode › should navigate client side for default locale with no prefix
● i18n Support basePath › production mode › should load getStaticProps fallback non-prerender page another locale correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale
● i18n Support basePath › production mode › should load getStaticProps non-fallback correctly another locale via cookie
● i18n Support basePath › production mode › should load getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should load dynamic getServerSideProps page correctly SSR
● i18n Support basePath › production mode › should navigate to another page and back correctly with locale
● i18n Support basePath › production mode › should navigate to getStaticProps page and back correctly with locale
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
buildDuration | 28.4s | 27.1s | N/A |
buildDurationCached | 25.3s | 21.6s | N/A |
nodeModulesSize | 392 MB | 392 MB | |
nextStartRea..uration (ms) | 745ms | 720ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
5306-HASH.js gzip | 54 kB | 53.9 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 241 B | 242 B | N/A |
main-HASH.js gzip | 34.5 kB | 34.4 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 52.9 kB | 52.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 537 B | 538 B | N/A |
withRouter.html gzip | 518 B | 519 B | N/A |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 210 kB | 210 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 670 B | 664 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 386 kB | 386 kB | N/A |
app-page-exp..prod.js gzip | 131 kB | 131 kB | ✓ |
app-page-tur..prod.js gzip | 144 kB | 144 kB | ✓ |
app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
app-page.run...dev.js gzip | 373 kB | 373 kB | N/A |
app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
app-route-ex...dev.js gzip | 39.4 kB | 39.4 kB | ✓ |
app-route-ex..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 25 kB | 25 kB | ✓ |
app-route-tu..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
app-route.ru...dev.js gzip | 41 kB | 41 kB | ✓ |
app-route.ru..prod.js gzip | 24.8 kB | 24.8 kB | ✓ |
dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
pages-api-tu..prod.js gzip | 8.81 kB | 8.81 kB | ✓ |
pages-api.ru...dev.js gzip | 11.5 kB | 11.5 kB | ✓ |
pages-api.ru..prod.js gzip | 8.8 kB | 8.8 kB | ✓ |
pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
pages.runtim...dev.js gzip | 31.3 kB | 31.3 kB | N/A |
pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
server.runti..prod.js gzip | 73.7 kB | 73.7 kB | ✓ |
Overall change | 870 kB | 870 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-28-right_align_feedback_buttons | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.1 MB | |
index.pack gzip | 75.7 kB | 74.6 kB | N/A |
Overall change | 2.1 MB | 2.1 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for pages.runtime.dev.js
Diff too large to display
Right align feedback button when there is no
footerMessage
.Before:
After:
Closes https://linear.app/vercel/issue/NDX-688/fix-footer-feedback-style-regression