[DevOverlay] Display Correct Number of Errors on Indicator #75395

devjiwonchoi · 2025-01-28T12:44:30Z

Why?

The indicator has displayed only the number of Runtime errors.

How?

If there is a build error or a missing HTML tag error, display the length of the errors as they need to be resolved before the runtime errors.

Before

After

Closes NDX-691

devjiwonchoi · 2025-01-28T12:44:50Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-01-28T12:49:45Z

Tests Passed

ijjk · 2025-01-28T12:51:37Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
buildDuration	17.3s	14.7s	N/A
buildDurationCached	13.9s	11.5s	N/A
nodeModulesSize	392 MB	392 MB	⚠️ +7.29 kB
nextStartRea..uration (ms)	396ms	408ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
5306-HASH.js gzip	54 kB	53.9 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	243 B	N/A
main-HASH.js gzip	34.5 kB	34.4 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
index.html gzip	523 B	523 B	✓
link.html gzip	537 B	538 B	N/A
withRouter.html gzip	518 B	519 B	N/A
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
middleware-b..fest.js gzip	669 B	665 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
app-page-exp...dev.js gzip	386 kB	386 kB	N/A
app-page-exp..prod.js gzip	131 kB	131 kB	✓
app-page-tur..prod.js gzip	144 kB	144 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page.run...dev.js gzip	373 kB	373 kB	N/A
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25 kB	25 kB	✓
app-route-tu..prod.js gzip	25 kB	25 kB	✓
app-route-tu..prod.js gzip	24.8 kB	24.8 kB	✓
app-route.ru...dev.js gzip	41 kB	41 kB	✓
app-route.ru..prod.js gzip	24.8 kB	24.8 kB	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
pages-api-tu..prod.js gzip	8.81 kB	8.81 kB	✓
pages-api.ru...dev.js gzip	11.5 kB	11.5 kB	✓
pages-api.ru..prod.js gzip	8.8 kB	8.8 kB	✓
pages-turbo...prod.js gzip	21.6 kB	21.6 kB	✓
pages.runtim...dev.js gzip	31.3 kB	31.3 kB	✓
pages.runtim..prod.js gzip	21.6 kB	21.6 kB	✓
server.runti..prod.js gzip	73.7 kB	73.7 kB	✓
Overall change	901 kB	901 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 01-28-_devoverlay_display_correct_number_of_errors_on_indicator	Change
0.pack gzip	2.1 MB	2.1 MB	N/A
index.pack gzip	74.7 kB	75.3 kB	⚠️ +673 B
Overall change	74.7 kB	75.3 kB	⚠️ +673 B

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page.runtime.dev.js

failed to diff

Diff for pages.runtime.dev.js

Diff too large to display

Commit: d3fdca9

packages/next/src/client/components/react-dev-overlay/_experimental/app/react-dev-overlay.tsx

huozhi · 2025-01-28T14:02:16Z

packages/next/src/client/components/react-dev-overlay/_experimental/app/react-dev-overlay.tsx

@@ -22,7 +22,10 @@ export default function ReactDevOverlay({
  children: React.ReactNode
 }) {
  const [isErrorOverlayOpen, setIsErrorOverlayOpen] = useState(false)
-  const { readyErrors } = useErrorHook({ errors: state.errors, isAppDir: true })
+  const { readyErrors, totalErrorsLength } = useErrorHook({


a note for future, we should rename readyErrors to runtimeErrors. ready is not a type of error. The type was called ReadyRuntimeError still indicating it's from runtime, separately from build errors

Yeah sounds good.

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

[DevOverlay] Display Correct Number of Errors on Indicator

ff80d12

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 28, 2025

devjiwonchoi marked this pull request as ready for review January 28, 2025 12:53

huozhi reviewed Jan 28, 2025

View reviewed changes

errors length to error count

d3fdca9

Co-authored-by: Jiachi Liu <inbox@huozhi.im>

devjiwonchoi requested review from huozhi, eps1lon and gaojude January 28, 2025 17:19

huozhi approved these changes Jan 28, 2025

View reviewed changes

devjiwonchoi mentioned this pull request Jan 28, 2025

[dev-overlay] fix: do not open error overlay when click indicator #75404

Merged

devjiwonchoi merged commit 0383d0b into canary Jan 28, 2025
131 checks passed

devjiwonchoi deleted the 01-28-_devoverlay_display_correct_number_of_errors_on_indicator branch January 28, 2025 18:58

devjiwonchoi mentioned this pull request Jan 28, 2025

[dev-overlay] do not close overlay when click indicator elements #75406

Merged

github-actions bot added the locked label Feb 26, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DevOverlay] Display Correct Number of Errors on Indicator #75395

[DevOverlay] Display Correct Number of Errors on Indicator #75395

devjiwonchoi commented Jan 28, 2025 •

edited

Loading

devjiwonchoi commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

huozhi Jan 28, 2025

devjiwonchoi Jan 28, 2025

[DevOverlay] Display Correct Number of Errors on Indicator #75395

[DevOverlay] Display Correct Number of Errors on Indicator #75395

Conversation

devjiwonchoi commented Jan 28, 2025 • edited Loading

Why?

How?

Before

After

devjiwonchoi commented Jan 28, 2025 • edited Loading

ijjk commented Jan 28, 2025 • edited Loading

Tests Passed

ijjk commented Jan 28, 2025 • edited Loading

Stats from current PR

huozhi Jan 28, 2025

Choose a reason for hiding this comment

devjiwonchoi Jan 28, 2025

Choose a reason for hiding this comment

devjiwonchoi commented Jan 28, 2025 •

edited

Loading

devjiwonchoi commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading