Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] cleanup tracing spans and names #75385

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions turbopack/crates/turbopack-cli/src/build/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use std::{
};

use anyhow::{bail, Context, Result};
use tracing::Instrument;
use turbo_rcstr::RcStr;
use turbo_tasks::{
apply_effects, ReadConsistency, ResolvedVc, TransientInstance, TryJoinIterExt, TurboTasks,
Expand Down Expand Up @@ -169,10 +168,8 @@ impl TurbopackBuildBuilder {
Ok(Default::default())
});

let span: tracing::Span = tracing::info_span!("Building project");
self.turbo_tasks
.wait_task_completion(task, ReadConsistency::Strong)
.instrument(span)
.await?;

Ok(())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ impl VarGraph {

/// You should use same [Mark] for this function and
/// [swc_ecma_transforms_base::resolver::resolver_with_mark]
#[tracing::instrument(level = "info", skip_all)]
pub fn create_graph(m: &Program, eval_context: &EvalContext) -> VarGraph {
let mut graph = VarGraph {
values: Default::default(),
Expand Down
Loading
Loading