refactor(turbopack): Remove ReadRawVcFuture.turbo_task

[kdy1]

What?

Why?

core::ptr::drop_in_place of ReadRawVcFuture.turbo_task is consuming too much time.

How?

Closes PACK-3800

[kdy1]

• refactor(turbopack): Remove ReadRawVcFuture.turbo_task #75217 👈 (View in Graphite)
• perf(turbopack): Use Cow::into_owned instead of .to_string() #75216
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Failing test suites

Commit: 01f1e63

pnpm test-start-turbo test/e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts (turbopack)

• segment cache (incremental opt in) > when prefetching with prefetch=true, refetches partial cache entries even if there's already a pending PPR request

Expand output

● segment cache (incremental opt in) › when prefetching with prefetch=true, refetches partial cache entries even if there's already a pending PPR request

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  228 |   )
  229 |
> 230 |   it(
      |   ^
  231 |     'when prefetching with prefetch=true, refetches partial cache entries ' +
  232 |       "even if there's already a pending PPR request",
  233 |     async () => {

  at it (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:230:3)
  at Object.describe (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:5:1)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
buildDuration	19.9s	17s	N/A
buildDurationCached	16.1s	13.5s	N/A
nodeModulesSize	419 MB	419 MB	N/A
nextStartRea..uration (ms)	442ms	441ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
5306-HASH.js gzip	54.1 kB	54.1 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.6 kB	34.6 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
index.html gzip	523 B	524 B	N/A
link.html gzip	539 B	537 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
middleware-b..fest.js gzip	670 B	667 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	378 kB	378 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	365 kB	365 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	27.7 kB	27.7 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.49 MB	2.49 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js kdy1/perf-arc-drop	Change
0.pack gzip	2.1 MB	2.11 MB	⚠️ +1.81 kB
index.pack gzip	75.1 kB	75.3 kB	⚠️ +190 B
Overall change	2.18 MB	2.18 MB	⚠️ +2 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 01f1e63