Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] fix invalidation and counting with collectibles #75195

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 22, 2025

What?

  • invalidate tasks when collectibles change
  • fix bug where collectibles are double counted

Closes PACK-3790

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 22, 2025
Copy link
Member Author

sokra commented Jan 22, 2025

@sokra sokra changed the title Invalidate when task collectibles change [Turbopack] fix invalidation and counting with collectibles Jan 22, 2025
@sokra sokra force-pushed the sokra/fix-collectibles-counting branch from 94811b7 to 7f88838 Compare January 22, 2025 18:19
Comment on lines -206 to -213
collectibles_update.extend(iter_many!(
task,
Collectible {
collectible
} count => {
(collectible, *count)
}
));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the primary bug. It is already added on line 189, so adding it here again will add it twice.

@ijjk
Copy link
Member

ijjk commented Jan 22, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
buildDuration 18.6s 15.4s N/A
buildDurationCached 14.4s 12.1s N/A
nodeModulesSize 419 MB 419 MB
nextStartRea..uration (ms) 416ms 416ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
index.html gzip 524 B 523 B N/A
link.html gzip 540 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 209 kB 209 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 376 kB 376 kB
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 364 kB 364 kB
app-page.run..prod.js gzip 127 kB 127 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.48 MB 2.48 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-collectibles-counting Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +3.46 kB
index.pack gzip 74.6 kB 74.9 kB ⚠️ +300 B
Overall change 2.17 MB 2.18 MB ⚠️ +3.76 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: dc4a609

@ijjk
Copy link
Member

ijjk commented Jan 22, 2025

Tests Passed

@sokra sokra requested a review from bgw January 22, 2025 19:15
@sokra sokra marked this pull request as ready for review January 22, 2025 19:15
@sokra sokra merged commit 208f6f9 into canary Jan 22, 2025
133 checks passed
@sokra sokra deleted the sokra/fix-collectibles-counting branch January 22, 2025 19:26
@github-actions github-actions bot added the locked label Feb 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants